Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: content/browser/service_worker/service_worker_write_to_cache_job.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_write_to_cache_job.h
diff --git a/content/browser/service_worker/service_worker_write_to_cache_job.h b/content/browser/service_worker/service_worker_write_to_cache_job.h
index be4e4e91a12633e5eb7fd48a7322206c4fec5382..ec3bfa7464be74176ffadaa9c1622f5b9aa8cf14 100644
--- a/content/browser/service_worker/service_worker_write_to_cache_job.h
+++ b/content/browser/service_worker/service_worker_write_to_cache_job.h
@@ -49,21 +49,18 @@ class CONTENT_EXPORT ServiceWorkerWriteToCacheJob
FRIEND_TEST_ALL_PREFIXES(ServiceWorkerContextRequestHandlerTest,
UpdateAfter24Hours);
- virtual ~ServiceWorkerWriteToCacheJob();
+ ~ServiceWorkerWriteToCacheJob() override;
// net::URLRequestJob overrides
- virtual void Start() override;
- virtual void Kill() override;
- virtual net::LoadState GetLoadState() const override;
- virtual bool GetCharset(std::string* charset) override;
- virtual bool GetMimeType(std::string* mime_type) const override;
- virtual void GetResponseInfo(net::HttpResponseInfo* info) override;
- virtual int GetResponseCode() const override;
- virtual void SetExtraRequestHeaders(
- const net::HttpRequestHeaders& headers) override;
- virtual bool ReadRawData(net::IOBuffer* buf,
- int buf_size,
- int *bytes_read) override;
+ void Start() override;
+ void Kill() override;
+ net::LoadState GetLoadState() const override;
+ bool GetCharset(std::string* charset) override;
+ bool GetMimeType(std::string* mime_type) const override;
+ void GetResponseInfo(net::HttpResponseInfo* info) override;
+ int GetResponseCode() const override;
+ void SetExtraRequestHeaders(const net::HttpRequestHeaders& headers) override;
+ bool ReadRawData(net::IOBuffer* buf, int buf_size, int* bytes_read) override;
const net::HttpResponseInfo* http_info() const;
@@ -81,27 +78,20 @@ class CONTENT_EXPORT ServiceWorkerWriteToCacheJob
void OnWriteDataComplete(int result);
// net::URLRequest::Delegate overrides that observe the net request.
- virtual void OnReceivedRedirect(
- net::URLRequest* request,
- const net::RedirectInfo& redirect_info,
- bool* defer_redirect) override;
- virtual void OnAuthRequired(
- net::URLRequest* request,
- net::AuthChallengeInfo* auth_info) override;
- virtual void OnCertificateRequested(
+ void OnReceivedRedirect(net::URLRequest* request,
+ const net::RedirectInfo& redirect_info,
+ bool* defer_redirect) override;
+ void OnAuthRequired(net::URLRequest* request,
+ net::AuthChallengeInfo* auth_info) override;
+ void OnCertificateRequested(
net::URLRequest* request,
net::SSLCertRequestInfo* cert_request_info) override;
- virtual void OnSSLCertificateError(
- net::URLRequest* request,
- const net::SSLInfo& ssl_info,
- bool fatal) override;
- virtual void OnBeforeNetworkStart(
- net::URLRequest* request,
- bool* defer) override;
- virtual void OnResponseStarted(net::URLRequest* request) override;
- virtual void OnReadCompleted(
- net::URLRequest* request,
- int bytes_read) override;
+ void OnSSLCertificateError(net::URLRequest* request,
+ const net::SSLInfo& ssl_info,
+ bool fatal) override;
+ void OnBeforeNetworkStart(net::URLRequest* request, bool* defer) override;
+ void OnResponseStarted(net::URLRequest* request) override;
+ void OnReadCompleted(net::URLRequest* request, int bytes_read) override;
void AsyncNotifyDoneHelper(const net::URLRequestStatus& status);
« no previous file with comments | « content/browser/service_worker/service_worker_version_unittest.cc ('k') | content/browser/session_history_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698