content/browser/service_worker/service_worker_version.h - Issue 667943003: Standardize usage of virtual/override/final in content/browser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 667943003: Standardize usage of virtual/override/final in content/browser/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_url_request_job_unittest.cc ('k') | content/browser/service_worker/service_worker_version_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version.h

diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h

index 7195bfb8987ce0dd938358847a9535b3e52a60af..24dd459dfb369ab05a3bc5032207fa120a79a985 100644

--- a/content/browser/service_worker/service_worker_version.h

+++ b/content/browser/service_worker/service_worker_version.h

@@ -229,21 +229,21 @@ class CONTENT_EXPORT ServiceWorkerVersion

typedef std::map<ServiceWorkerProviderHost*, int> ControlleeMap;

typedef IDMap<ServiceWorkerProviderHost> ControlleeByIDMap;

- virtual ~ServiceWorkerVersion();

+ ~ServiceWorkerVersion() override;

// EmbeddedWorkerInstance::Listener overrides:

- virtual void OnStarted() override;

- virtual void OnStopped() override;

- virtual void OnReportException(const base::string16& error_message,

- int line_number,

- int column_number,

- const GURL& source_url) override;

- virtual void OnReportConsoleMessage(int source_identifier,

- int message_level,

- const base::string16& message,

- int line_number,

- const GURL& source_url) override;

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ void OnStarted() override;

+ void OnStopped() override;

+ void OnReportException(const base::string16& error_message,

+ int line_number,

+ int column_number,

+ const GURL& source_url) override;

+ void OnReportConsoleMessage(int source_identifier,

+ int message_level,

+ const base::string16& message,

+ int line_number,

+ const GURL& source_url) override;

+ bool OnMessageReceived(const IPC::Message& message) override;

void OnStartMessageSent(ServiceWorkerStatusCode status);