net/socket/websocket_transport_connect_sub_job.h - Issue 667923003: Standardize usage of virtual/override/final in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/websocket_transport_connect_sub_job.h

Issue 667923003: Standardize usage of virtual/override/final in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/websocket_transport_connect_sub_job.h

diff --git a/net/socket/websocket_transport_connect_sub_job.h b/net/socket/websocket_transport_connect_sub_job.h

index e6f81e82f4bb9166101d98f5f8be66fe54702bc5..5709a461cafef3ba6dba6a19e4b68f7abe6432d8 100644

--- a/net/socket/websocket_transport_connect_sub_job.h

+++ b/net/socket/websocket_transport_connect_sub_job.h

@@ -33,7 +33,7 @@ class WebSocketTransportConnectSubJob

WebSocketTransportConnectJob* parent_job,

SubJobType type);

- virtual ~WebSocketTransportConnectSubJob();

+ ~WebSocketTransportConnectSubJob() override;

// Start connecting.

int Start();

@@ -47,7 +47,7 @@ class WebSocketTransportConnectSubJob

scoped_ptr<StreamSocket> PassSocket() { return transport_socket_.Pass(); }

// Implementation of WebSocketEndpointLockManager::EndpointWaiter.

- virtual void GotEndpointLock() override;

+ void GotEndpointLock() override;

private:

enum State {