net/socket/websocket_transport_client_socket_pool_unittest.cc - Issue 667923003: Standardize usage of virtual/override/final in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/websocket_transport_client_socket_pool_unittest.cc

Issue 667923003: Standardize usage of virtual/override/final in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/websocket_transport_client_socket_pool_unittest.cc

diff --git a/net/socket/websocket_transport_client_socket_pool_unittest.cc b/net/socket/websocket_transport_client_socket_pool_unittest.cc

index bfb209036354e3332c7d73a63e60d1ac7c54c373..4d04c1077ff9b0b28e8e274db35ce5b37bd6c71c 100644

--- a/net/socket/websocket_transport_client_socket_pool_unittest.cc

+++ b/net/socket/websocket_transport_client_socket_pool_unittest.cc

@@ -382,7 +382,7 @@ class RequestSocketCallback : public TestCompletionCallbackBase {

callback_(base::Bind(&RequestSocketCallback::OnComplete,

base::Unretained(this))) {}

- virtual ~RequestSocketCallback() {}

+ ~RequestSocketCallback() override {}

const CompletionCallback& callback() const { return callback_; }