net/socket_stream/socket_stream.h - Issue 667923003: Standardize usage of virtual/override/final in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket_stream/socket_stream.h

Issue 667923003: Standardize usage of virtual/override/final in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket_stream/socket_stream.h

diff --git a/net/socket_stream/socket_stream.h b/net/socket_stream/socket_stream.h

index c9de0c15f6b7cfc007dd8cbcde118b3d31bf8602..7387eb68a9b338d58c7fd26aef7a5ce8eef88eba 100644

--- a/net/socket_stream/socket_stream.h

+++ b/net/socket_stream/socket_stream.h

@@ -212,7 +212,7 @@ class NET_EXPORT SocketStream

std::string headers_;

private:

- virtual ~RequestHeaders();

+ ~RequestHeaders() override;

};

class ResponseHeaders : public IOBuffer {

@@ -225,7 +225,7 @@ class NET_EXPORT SocketStream

void Realloc(size_t new_size);

private:

- virtual ~ResponseHeaders();

+ ~ResponseHeaders() override;

scoped_ptr<char, base::FreeDeleter> headers_;

};