Issue 6677142: rename getBitmapDC to beginPlatformPaint and add calls to endPlatformPaint

Issue 6677142: rename getBitmapDC to beginPlatformPaint and add calls to endPlatformPaint (Closed)

Created:
9 years, 8 months ago by vandebo (ex-Chrome)

Modified:
9 years, 7 months ago

Reviewers:
Lei Zhang

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

rename getBitmapDC to beginPlatformPaint and add calls to endPlatformPaint This takes a step toward unifying the platform device interface between Windows and Linux and helps to make VectorPlatformDeviceSkia have less ifdefs. BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80474

Patch Set 1 #

Patch Set 2 : Fix compile problems #

Patch Set 3 : Update copyright years #

Total comments: 2

Patch Set 4 : Address comments #

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -53 lines)			Patch
M	skia/ext/bitmap_platform_device_win.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	skia/ext/bitmap_platform_device_win.cc	View	1 2 3	4 chunks	+4 lines, -3 lines	0 comments	Download
M	skia/ext/platform_canvas.h	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	skia/ext/platform_canvas_linux.cc	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	skia/ext/platform_canvas_mac.cc	View	1 2	2 chunks	+3 lines, -3 lines	0 comments	Download
M	skia/ext/platform_canvas_win.cc	View	1 2	2 chunks	+5 lines, -4 lines	0 comments	Download
M	skia/ext/platform_device_win.h	View	1 2	2 chunks	+5 lines, -2 lines	0 comments	Download
M	skia/ext/vector_canvas_unittest.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	skia/ext/vector_platform_device_emf_win.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	skia/ext/vector_platform_device_emf_win.cc	View	1 2 3	6 chunks	+6 lines, -3 lines	0 comments	Download
M	ui/gfx/blit.cc	View	1 2	3 chunks	+9 lines, -17 lines	0 comments	Download
M	ui/views/widget/native_widget_win.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	views/widget/widget_win.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View	1	4 chunks	+4 lines, -8 lines	0 comments	Download
M	webkit/tools/test_shell/webwidget_host_win.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

http://codereview.chromium.org/6677142/diff/14/skia/ext/bitmap_platform_device_win.cc File skia/ext/bitmap_platform_device_win.cc (right): http://codereview.chromium.org/6677142/diff/14/skia/ext/bitmap_platform_device_win.cc#newcode217 skia/ext/bitmap_platform_device_win.cc:217: HDC source_dc = beginPlatformPaint(); do you need a matching ...

9 years, 8 months ago (2011-04-05 00:18:16 UTC) #2

vandebo (ex-Chrome)

On 2011/04/05 00:18:16, Lei Zhang wrote: > do you need a matching endPlatformPaint() somewhere in ...

9 years, 8 months ago (2011-04-05 02:33:33 UTC) #3

LGTM

Expand Messages | Collapse Messages