Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 6677076: Merge up to bleeding_edge r7201 to isolates branch. (Closed)

Created:
9 years, 9 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

Merge up to bleeding_edge r7201 to isolates branch. Simple merges all the way through. Committed: http://code.google.com/p/v8/source/detail?r=7204

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Patch Set 3 : Fix lint. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1586 lines, -839 lines) Patch
M ChangeLog View 1 chunk +9 lines, -0 lines 0 comments Download
M MERGE View 1 chunk +1 line, -1 line 0 comments Download
M SConstruct View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/assembler-arm.h View 4 chunks +9 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 13 chunks +37 lines, -126 lines 0 comments Download
M src/arm/codegen-arm.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/codegen-arm.cc View 7 chunks +16 lines, -12 lines 0 comments Download
M src/arm/constants-arm.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/arm/disasm-arm.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 9 chunks +17 lines, -17 lines 0 comments Download
M src/arm/lithium-arm.h View 4 chunks +25 lines, -5 lines 0 comments Download
M src/arm/lithium-arm.cc View 4 chunks +34 lines, -10 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 7 chunks +143 lines, -70 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 2 chunks +26 lines, -5 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 26 chunks +154 lines, -44 lines 0 comments Download
M src/arm/simulator-arm.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M src/ast.h View 3 chunks +3 lines, -0 lines 0 comments Download
M src/ast.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-stubs.h View 2 chunks +0 lines, -13 lines 0 comments Download
M src/compiler.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/compiler.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M src/d8-posix.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/debug.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/deoptimizer.cc View 1 2 chunks +1 line, -8 lines 0 comments Download
M src/full-codegen.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 4 chunks +28 lines, -9 lines 0 comments Download
M src/hydrogen-instructions.h View 3 chunks +28 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.h View 3 chunks +7 lines, -0 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +4 lines, -55 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 10 chunks +19 lines, -19 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 3 chunks +102 lines, -34 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 2 chunks +24 lines, -7 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 19 chunks +20 lines, -20 lines 0 comments Download
M src/parser.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/platform.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/platform-freebsd.cc View 6 chunks +126 lines, -42 lines 0 comments Download
M src/runtime.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M src/v8natives.js View 5 chunks +51 lines, -10 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/assembler-x64.h View 5 chunks +11 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 8 chunks +23 lines, -68 lines 0 comments Download
M src/x64/codegen-x64.cc View 15 chunks +26 lines, -25 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 13 chunks +24 lines, -24 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 6 chunks +110 lines, -41 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +14 lines, -0 lines 0 comments Download
M src/x64/lithium-x64.cc View 2 chunks +24 lines, -7 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 3 chunks +6 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 27 chunks +64 lines, -28 lines 0 comments Download
A test/benchmarks/testcfg.py View 1 chunk +100 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 5 chunks +22 lines, -3 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/test-macro-assembler-x64.cc View 1 53 chunks +98 lines, -98 lines 0 comments Download
M test/cctest/testcfg.py View 2 chunks +2 lines, -0 lines 0 comments Download
M test/mjsunit/accessors-on-global-object.js View 3 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/bitops-info.js View 2 chunks +7 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-1240.js View 1 chunk +39 lines, -0 lines 0 comments Download
M test/mozilla/mozilla.status View 1 chunk +0 lines, -2 lines 0 comments Download
A tools/freebsd-tick-processor View 1 chunk +10 lines, -0 lines 0 comments Download
M tools/linux-tick-processor View 2 chunks +5 lines, -3 lines 0 comments Download
M tools/test.py View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Mads Ager (chromium)
9 years, 9 months ago (2011-03-16 12:28:29 UTC) #1
Mads Ager (chromium)
9 years, 9 months ago (2011-03-16 13:07:51 UTC) #2
Vitaly Repeshko
LGTM with comments. Thanks, Vitaly http://codereview.chromium.org/6677076/diff/1/src/deoptimizer.cc File src/deoptimizer.cc (right): http://codereview.chromium.org/6677076/diff/1/src/deoptimizer.cc#newcode930 src/deoptimizer.cc:930: static Mutex* flag_mutex = ...
9 years, 9 months ago (2011-03-16 13:21:50 UTC) #3
Mads Ager (chromium)
9 years, 9 months ago (2011-03-16 13:54:28 UTC) #4
http://codereview.chromium.org/6677076/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):

http://codereview.chromium.org/6677076/diff/1/src/deoptimizer.cc#newcode930
src/deoptimizer.cc:930: static Mutex* flag_mutex = OS::CreateMutex();
On 2011/03/16 13:21:50, Vitaly Repeshko wrote:
> Can be removed.

Done.

http://codereview.chromium.org/6677076/diff/1/test/cctest/test-macro-assemble...
File test/cctest/test-macro-assembler-x64.cc (right):

http://codereview.chromium.org/6677076/diff/1/test/cctest/test-macro-assemble...
test/cctest/test-macro-assembler-x64.cc:2100: <<<<<<< .working
On 2011/03/16 13:21:50, Vitaly Repeshko wrote:
> Huh?

Whoops, thanks. Fixed, running tests now.

Powered by Google App Engine
This is Rietveld 408576698