Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: tools/gn/setup.h

Issue 667143003: Standardize usage of virtual/override/final in tools/gn/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/setup.h
diff --git a/tools/gn/setup.h b/tools/gn/setup.h
index 558c54d3c4861edbf6608ffaa1b713fb9d97fac5..53730f7ff65d1b78d407e5bbba002e18d18dbfe7 100644
--- a/tools/gn/setup.h
+++ b/tools/gn/setup.h
@@ -90,7 +90,7 @@ class CommonSetup {
class Setup : public CommonSetup {
public:
Setup();
- virtual ~Setup();
+ ~Setup() override;
// Configures the build for the current command line. On success returns
// true. On failure, prints the error and returns false.
@@ -114,7 +114,7 @@ class Setup : public CommonSetup {
Scheduler& scheduler() { return scheduler_; }
- virtual Scheduler* GetScheduler() OVERRIDE;
+ Scheduler* GetScheduler() OVERRIDE;
// Returns the file used to store the build arguments. Note that the path
// might not exist.
@@ -202,14 +202,14 @@ class DependentSetup : public CommonSetup {
// default copy constructor.
DependentSetup(Setup* derive_from);
DependentSetup(DependentSetup* derive_from);
- virtual ~DependentSetup();
+ ~DependentSetup() override;
// These are the two parts of Run() in the regular setup, not including the
// call to actually run the message loop.
void RunPreMessageLoop();
bool RunPostMessageLoop();
- virtual Scheduler* GetScheduler() OVERRIDE;
+ Scheduler* GetScheduler() OVERRIDE;
private:
Scheduler* scheduler_;

Powered by Google App Engine
This is Rietveld 408576698