tools/gn/scope_per_file_provider.h - Issue 667143003: Standardize usage of virtual/override/final in tools/gn/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/scope_per_file_provider.h

Issue 667143003: Standardize usage of virtual/override/final in tools/gn/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/scope_per_file_provider.h

diff --git a/tools/gn/scope_per_file_provider.h b/tools/gn/scope_per_file_provider.h

index 2ef84cc8493864bb0553fcd016de4f58a7d99371..0470144e015fff86bfa8ea87b91a60910868b18c 100644

--- a/tools/gn/scope_per_file_provider.h

+++ b/tools/gn/scope_per_file_provider.h

@@ -21,8 +21,7 @@ class ScopePerFileProvider : public Scope::ProgrammaticProvider {

virtual ~ScopePerFileProvider();

// ProgrammaticProvider implementation.

- virtual const Value* GetProgrammaticValue(

- const base::StringPiece& ident) OVERRIDE;

+ const Value* GetProgrammaticValue(const base::StringPiece& ident) OVERRIDE;

private:

const Value* GetCurrentToolchain();

« tools/gn/action_target_generator.h ('K') | « tools/gn/parse_tree.h ('k') | tools/gn/setup.h » ('j') | no next file with comments »