Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: tools/gn/target.h

Issue 667143003: Standardize usage of virtual/override/final in tools/gn/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/target.h
diff --git a/tools/gn/target.h b/tools/gn/target.h
index 5b19aad6fc9c03f4fd7bba9f8b3c5922f5929e28..329a8f61074a781fd82197344a7628b466914c7c 100644
--- a/tools/gn/target.h
+++ b/tools/gn/target.h
@@ -52,15 +52,15 @@ class Target : public Item {
typedef std::vector<std::string> StringVector;
Target(const Settings* settings, const Label& label);
- virtual ~Target();
+ ~Target() override;
// Returns a string naming the output type.
static const char* GetStringForOutputType(OutputType type);
// Item overrides.
- virtual Target* AsTarget() OVERRIDE;
- virtual const Target* AsTarget() const OVERRIDE;
- virtual bool OnResolved(Err* err) OVERRIDE;
+ Target* AsTarget() OVERRIDE;
+ const Target* AsTarget() const OVERRIDE;
+ bool OnResolved(Err* err) OVERRIDE;
OutputType output_type() const { return output_type_; }
void set_output_type(OutputType t) { output_type_ = t; }
« tools/gn/action_target_generator.h ('K') | « tools/gn/setup.h ('k') | tools/gn/toolchain.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698