Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: components/bookmarks.gypi

Issue 666813002: GN: Fix Android component build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-clank
Patch Set: Actually undo gyp change Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'targets': [ 6 'targets': [
7 { 7 {
8 # GN version: //components/bookmarks/browser 8 # GN version: //components/bookmarks/browser
9 'target_name': 'bookmarks_browser', 9 'target_name': 'bookmarks_browser',
10 'type': 'static_library', 10 'type': 'static_library',
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 'bookmarks/browser/bookmark_pasteboard_helper_mac.mm', 53 'bookmarks/browser/bookmark_pasteboard_helper_mac.mm',
54 'bookmarks/browser/bookmark_storage.cc', 54 'bookmarks/browser/bookmark_storage.cc',
55 'bookmarks/browser/bookmark_storage.h', 55 'bookmarks/browser/bookmark_storage.h',
56 'bookmarks/browser/bookmark_utils.cc', 56 'bookmarks/browser/bookmark_utils.cc',
57 'bookmarks/browser/bookmark_utils.h', 57 'bookmarks/browser/bookmark_utils.h',
58 'bookmarks/browser/scoped_group_bookmark_actions.cc', 58 'bookmarks/browser/scoped_group_bookmark_actions.cc',
59 'bookmarks/browser/scoped_group_bookmark_actions.h', 59 'bookmarks/browser/scoped_group_bookmark_actions.h',
60 ], 60 ],
61 'conditions': [ 61 'conditions': [
62 ['OS == "android"', { 62 ['OS == "android"', {
63 # GN version: //components/bookmarks/common/android
jamesr 2014/10/22 00:28:18 "GN version" comments are normally on target defin
cjhopman 2014/10/23 00:15:48 Added clarification.
63 'dependencies': [ 64 'dependencies': [
64 'bookmarks_jni_headers', 65 'bookmarks_jni_headers',
65 ], 66 ],
66 'sources' : [ 67 'sources' : [
67 'bookmarks/common/android/bookmark_id.cc', 68 'bookmarks/common/android/bookmark_id.cc',
68 'bookmarks/common/android/bookmark_id.h', 69 'bookmarks/common/android/bookmark_id.h',
69 'bookmarks/common/android/bookmark_type_list.h', 70 'bookmarks/common/android/bookmark_type_list.h',
70 'bookmarks/common/android/component_jni_registrar.cc', 71 'bookmarks/common/android/component_jni_registrar.cc',
71 'bookmarks/common/android/component_jni_registrar.h', 72 'bookmarks/common/android/component_jni_registrar.h',
72 ], 73 ],
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 'variables': { 160 'variables': {
160 'package_name': 'org/chromium/components/bookmarks', 161 'package_name': 'org/chromium/components/bookmarks',
161 'template_deps': ['bookmarks/common/android/bookmark_type_list.h'], 162 'template_deps': ['bookmarks/common/android/bookmark_type_list.h'],
162 }, 163 },
163 'includes': [ '../build/android/java_cpp_template.gypi' ], 164 'includes': [ '../build/android/java_cpp_template.gypi' ],
164 }, 165 },
165 ], 166 ],
166 }] 167 }]
167 ], 168 ],
168 } 169 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698