Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1949)

Unified Diff: chrome/browser/ui/android/chrome_javascript_native_dialog_factory_android.cc

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/chrome_javascript_native_dialog_factory_android.cc
diff --git a/chrome/browser/ui/android/chrome_javascript_native_dialog_factory_android.cc b/chrome/browser/ui/android/chrome_javascript_native_dialog_factory_android.cc
new file mode 100644
index 0000000000000000000000000000000000000000..bc5dd6960c9fc5ca3c7934c618552fde4fedf1e7
--- /dev/null
+++ b/chrome/browser/ui/android/chrome_javascript_native_dialog_factory_android.cc
@@ -0,0 +1,38 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
msw 2014/11/05 03:53:54 Perhaps everything in this file could still live i
oshima 2014/11/05 21:42:18 I put this in separate file because I thought it's
Avi (use Gerrit) 2014/11/05 21:50:40 I don't have strong opinions and would be OK eithe
msw 2014/11/05 22:59:06 I slightly favor combining the files, but don't ha
oshima 2014/11/05 23:22:48 I've moved to javascript_app_modal_dialog_android.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/app_modal_dialogs/chrome_javascript_native_dialog_factory.h"
+
+#include "base/android/jni_android.h"
+#include "chrome/browser/ui/android/javascript_app_modal_dialog_android.h"
+#include "components/app_modal_dialogs/javascript_dialog_manager.h"
+#include "components/app_modal_dialogs/javascript_native_dialog_factory.h"
+
+namespace {
+
+class ChromeJavaScriptNativeDialogAndroidFactory
+ : public JavaScriptNativeDialogFactory {
+ public:
+ ChromeJavaScriptNativeDialogAndroidFactory() {}
+ ~ChromeJavaScriptNativeDialogAndroidFactory() override {}
+
+ private:
+ NativeAppModalDialog* CreateNativeJavaScriptDialog(
+ JavaScriptAppModalDialog* dialog,
+ gfx::NativeWindow parent_window) override {
+ return new JavascriptAppModalDialogAndroid(
+ base::android::AttachCurrentThread(),
+ dialog, parent_window);
+ }
+
+ DISALLOW_COPY_AND_ASSIGN(ChromeJavaScriptNativeDialogAndroidFactory);
+};
+
+} // namespace
+
+void InstallChromeJavaScriptNativeDialogFactory() {
+ SetJavaScriptNativeDialogFactory(
+ make_scoped_ptr(new ChromeJavaScriptNativeDialogAndroidFactory));
+}
+

Powered by Google App Engine
This is Rietveld 408576698