Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5898)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 666533007: Move JavaScriptDialogManager, JavascriptAppModalDialogViews to components/app_modal_dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/chrome_browser_main.cc ('K') | « chrome/browser/extensions/chrome_extension_host_delegate.cc ('k') | chrome/browser/ui/android/chrome_javascript_native_dialog_factory_android.cc » ('j') | chrome/browser/ui/android/chrome_javascript_native_dialog_factory_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/BUILD.gn
diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn
index c0af2d707ec5e98541d7af2ef07d493cff05766f..25cc8905a4bba2607e7bad6b987f45c410a1a69d 100644
--- a/chrome/browser/ui/BUILD.gn
+++ b/chrome/browser/ui/BUILD.gn
@@ -46,7 +46,6 @@ static_library("ui") {
"//chrome/browser/net:cert_logger_proto",
"//chrome/common",
"//chrome/common/net",
- "//components/app_modal_dialogs",
msw 2014/11/05 03:53:54 Doesn't chrome/browser/ui/browser.cc still use thi
oshima 2014/11/05 21:42:18 I thought this depends on browser but apparently n
"//components/auto_login_parser",
"//components/dom_distiller/webui",
"//components/feedback/proto",
« chrome/browser/chrome_browser_main.cc ('K') | « chrome/browser/extensions/chrome_extension_host_delegate.cc ('k') | chrome/browser/ui/android/chrome_javascript_native_dialog_factory_android.cc » ('j') | chrome/browser/ui/android/chrome_javascript_native_dialog_factory_android.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698