Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7457)

Unified Diff: chrome/browser/extensions/api/identity/web_auth_flow.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/identity/web_auth_flow.h
diff --git a/chrome/browser/extensions/api/identity/web_auth_flow.h b/chrome/browser/extensions/api/identity/web_auth_flow.h
index dccc5f0a1e7eea6afa773cc2e759ea2b23edafb4..b7b31aa94383108c0be0f607a460024c066e459c 100644
--- a/chrome/browser/extensions/api/identity/web_auth_flow.h
+++ b/chrome/browser/extensions/api/identity/web_auth_flow.h
@@ -80,7 +80,7 @@ class WebAuthFlow : public content::NotificationObserver,
const GURL& provider_url,
Mode mode);
- virtual ~WebAuthFlow();
+ ~WebAuthFlow() override;
// Starts the flow.
virtual void Start();
@@ -92,31 +92,29 @@ class WebAuthFlow : public content::NotificationObserver,
friend class ::WebAuthFlowTest;
// ::AppWindowRegistry::Observer implementation.
- virtual void OnAppWindowAdded(AppWindow* app_window) override;
- virtual void OnAppWindowRemoved(AppWindow* app_window) override;
+ void OnAppWindowAdded(AppWindow* app_window) override;
+ void OnAppWindowRemoved(AppWindow* app_window) override;
// NotificationObserver implementation.
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) override;
+ void Observe(int type,
+ const content::NotificationSource& source,
+ const content::NotificationDetails& details) override;
// WebContentsObserver implementation.
- virtual void DidStopLoading(content::RenderViewHost* render_view_host)
- override;
- virtual void DidNavigateMainFrame(
+ void DidStopLoading(content::RenderViewHost* render_view_host) override;
+ void DidNavigateMainFrame(
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params) override;
- virtual void RenderProcessGone(base::TerminationStatus status) override;
- virtual void DidStartProvisionalLoadForFrame(
+ void RenderProcessGone(base::TerminationStatus status) override;
+ void DidStartProvisionalLoadForFrame(
content::RenderFrameHost* render_frame_host,
const GURL& validated_url,
bool is_error_page,
bool is_iframe_srcdoc) override;
- virtual void DidFailProvisionalLoad(
- content::RenderFrameHost* render_frame_host,
- const GURL& validated_url,
- int error_code,
- const base::string16& error_description) override;
+ void DidFailProvisionalLoad(content::RenderFrameHost* render_frame_host,
+ const GURL& validated_url,
+ int error_code,
+ const base::string16& error_description) override;
void BeforeUrlLoaded(const GURL& url);
void AfterUrlLoaded();

Powered by Google App Engine
This is Rietveld 408576698