Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Side by Side Diff: chrome/browser/extensions/api/identity/web_auth_flow.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_IDENTITY_WEB_AUTH_FLOW_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_IDENTITY_WEB_AUTH_FLOW_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_IDENTITY_WEB_AUTH_FLOW_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_IDENTITY_WEB_AUTH_FLOW_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "content/public/browser/notification_observer.h" 10 #include "content/public/browser/notification_observer.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 virtual ~Delegate() {} 73 virtual ~Delegate() {}
74 }; 74 };
75 75
76 // Creates an instance with the given parameters. 76 // Creates an instance with the given parameters.
77 // Caller owns |delegate|. 77 // Caller owns |delegate|.
78 WebAuthFlow(Delegate* delegate, 78 WebAuthFlow(Delegate* delegate,
79 Profile* profile, 79 Profile* profile,
80 const GURL& provider_url, 80 const GURL& provider_url,
81 Mode mode); 81 Mode mode);
82 82
83 virtual ~WebAuthFlow(); 83 ~WebAuthFlow() override;
84 84
85 // Starts the flow. 85 // Starts the flow.
86 virtual void Start(); 86 virtual void Start();
87 87
88 // Prevents further calls to the delegate and deletes the flow. 88 // Prevents further calls to the delegate and deletes the flow.
89 void DetachDelegateAndDelete(); 89 void DetachDelegateAndDelete();
90 90
91 private: 91 private:
92 friend class ::WebAuthFlowTest; 92 friend class ::WebAuthFlowTest;
93 93
94 // ::AppWindowRegistry::Observer implementation. 94 // ::AppWindowRegistry::Observer implementation.
95 virtual void OnAppWindowAdded(AppWindow* app_window) override; 95 void OnAppWindowAdded(AppWindow* app_window) override;
96 virtual void OnAppWindowRemoved(AppWindow* app_window) override; 96 void OnAppWindowRemoved(AppWindow* app_window) override;
97 97
98 // NotificationObserver implementation. 98 // NotificationObserver implementation.
99 virtual void Observe(int type, 99 void Observe(int type,
100 const content::NotificationSource& source, 100 const content::NotificationSource& source,
101 const content::NotificationDetails& details) override; 101 const content::NotificationDetails& details) override;
102 102
103 // WebContentsObserver implementation. 103 // WebContentsObserver implementation.
104 virtual void DidStopLoading(content::RenderViewHost* render_view_host) 104 void DidStopLoading(content::RenderViewHost* render_view_host) override;
105 override; 105 void DidNavigateMainFrame(
106 virtual void DidNavigateMainFrame(
107 const content::LoadCommittedDetails& details, 106 const content::LoadCommittedDetails& details,
108 const content::FrameNavigateParams& params) override; 107 const content::FrameNavigateParams& params) override;
109 virtual void RenderProcessGone(base::TerminationStatus status) override; 108 void RenderProcessGone(base::TerminationStatus status) override;
110 virtual void DidStartProvisionalLoadForFrame( 109 void DidStartProvisionalLoadForFrame(
111 content::RenderFrameHost* render_frame_host, 110 content::RenderFrameHost* render_frame_host,
112 const GURL& validated_url, 111 const GURL& validated_url,
113 bool is_error_page, 112 bool is_error_page,
114 bool is_iframe_srcdoc) override; 113 bool is_iframe_srcdoc) override;
115 virtual void DidFailProvisionalLoad( 114 void DidFailProvisionalLoad(content::RenderFrameHost* render_frame_host,
116 content::RenderFrameHost* render_frame_host, 115 const GURL& validated_url,
117 const GURL& validated_url, 116 int error_code,
118 int error_code, 117 const base::string16& error_description) override;
119 const base::string16& error_description) override;
120 118
121 void BeforeUrlLoaded(const GURL& url); 119 void BeforeUrlLoaded(const GURL& url);
122 void AfterUrlLoaded(); 120 void AfterUrlLoaded();
123 121
124 Delegate* delegate_; 122 Delegate* delegate_;
125 Profile* profile_; 123 Profile* profile_;
126 GURL provider_url_; 124 GURL provider_url_;
127 Mode mode_; 125 Mode mode_;
128 126
129 AppWindow* app_window_; 127 AppWindow* app_window_;
130 std::string app_window_key_; 128 std::string app_window_key_;
131 bool embedded_window_created_; 129 bool embedded_window_created_;
132 130
133 content::NotificationRegistrar registrar_; 131 content::NotificationRegistrar registrar_;
134 132
135 DISALLOW_COPY_AND_ASSIGN(WebAuthFlow); 133 DISALLOW_COPY_AND_ASSIGN(WebAuthFlow);
136 }; 134 };
137 135
138 } // namespace extensions 136 } // namespace extensions
139 137
140 #endif // CHROME_BROWSER_EXTENSIONS_API_IDENTITY_WEB_AUTH_FLOW_H_ 138 #endif // CHROME_BROWSER_EXTENSIONS_API_IDENTITY_WEB_AUTH_FLOW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698