chrome/browser/extensions/api/identity/identity_signin_flow.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/identity_signin_flow.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/identity/identity_apitest.cc ('k') | chrome/browser/extensions/api/identity/web_auth_flow.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/identity/identity_signin_flow.h

diff --git a/chrome/browser/extensions/api/identity/identity_signin_flow.h b/chrome/browser/extensions/api/identity/identity_signin_flow.h

index 9a0d64683a9cf0683f04afeb4c234a5bfcc8e1e3..5f443f5137530da5517d7a5ce6ec9d04068e9172 100644

--- a/chrome/browser/extensions/api/identity/identity_signin_flow.h

+++ b/chrome/browser/extensions/api/identity/identity_signin_flow.h

@@ -34,13 +34,13 @@ class IdentitySigninFlow : public OAuth2TokenService::Observer {

IdentitySigninFlow(Delegate* delegate,

Profile* profile);

- virtual ~IdentitySigninFlow();

+ ~IdentitySigninFlow() override;

// Starts the flow. Should only be called once.

void Start();

// OAuth2TokenService::Observer implementation:

- virtual void OnRefreshTokenAvailable(const std::string& account_id) override;

+ void OnRefreshTokenAvailable(const std::string& account_id) override;

private:

Delegate* delegate_;