chrome/browser/extensions/api/storage/sync_storage_backend.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/sync_storage_backend.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/storage/settings_sync_unittest.cc ('k') | chrome/browser/extensions/api/storage/sync_value_store_cache.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/storage/sync_storage_backend.h

diff --git a/chrome/browser/extensions/api/storage/sync_storage_backend.h b/chrome/browser/extensions/api/storage/sync_storage_backend.h

index ad816778e8e63e458fa95ceac21bbd7fcb82b3d2..080fa8e7e3d9d9e8fcb27284f1ba91129909ea09 100644

--- a/chrome/browser/extensions/api/storage/sync_storage_backend.h

+++ b/chrome/browser/extensions/api/storage/sync_storage_backend.h

@@ -45,23 +45,22 @@ class SyncStorageBackend : public syncer::SyncableService {

syncer::ModelType sync_type,

const syncer::SyncableService::StartSyncFlare& flare);

- virtual ~SyncStorageBackend();

+ ~SyncStorageBackend() override;

virtual ValueStore* GetStorage(const std::string& extension_id);

virtual void DeleteStorage(const std::string& extension_id);

// syncer::SyncableService implementation.

- virtual syncer::SyncDataList GetAllSyncData(syncer::ModelType type)

- const override;

- virtual syncer::SyncMergeResult MergeDataAndStartSyncing(

+ syncer::SyncDataList GetAllSyncData(syncer::ModelType type) const override;

+ syncer::SyncMergeResult MergeDataAndStartSyncing(

syncer::ModelType type,

const syncer::SyncDataList& initial_sync_data,

scoped_ptr<syncer::SyncChangeProcessor> sync_processor,

scoped_ptr<syncer::SyncErrorFactory> sync_error_factory) override;

- virtual syncer::SyncError ProcessSyncChanges(

+ syncer::SyncError ProcessSyncChanges(

const tracked_objects::Location& from_here,

const syncer::SyncChangeList& change_list) override;

- virtual void StopSyncing(syncer::ModelType type) override;

+ void StopSyncing(syncer::ModelType type) override;

private:

// Gets a weak reference to the storage area for a given extension,