Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: chrome/browser/extensions/api/storage/settings_sync_unittest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/storage/settings_sync_unittest.cc
diff --git a/chrome/browser/extensions/api/storage/settings_sync_unittest.cc b/chrome/browser/extensions/api/storage/settings_sync_unittest.cc
index b099fc03ccf2d9803fbe2e81f92b331e8f643227..752b899eea53bb72b2de0a73b39eda8b00e84e70 100644
--- a/chrome/browser/extensions/api/storage/settings_sync_unittest.cc
+++ b/chrome/browser/extensions/api/storage/settings_sync_unittest.cc
@@ -95,7 +95,7 @@ class MockSyncChangeProcessor : public syncer::SyncChangeProcessor {
MockSyncChangeProcessor() : fail_all_requests_(false) {}
// syncer::SyncChangeProcessor implementation.
- virtual syncer::SyncError ProcessSyncChanges(
+ syncer::SyncError ProcessSyncChanges(
const tracked_objects::Location& from_here,
const syncer::SyncChangeList& change_list) override {
if (fail_all_requests_) {
@@ -112,8 +112,7 @@ class MockSyncChangeProcessor : public syncer::SyncChangeProcessor {
return syncer::SyncError();
}
- virtual syncer::SyncDataList GetAllSyncData(syncer::ModelType type) const
- override {
+ syncer::SyncDataList GetAllSyncData(syncer::ModelType type) const override {
return syncer::SyncDataList();
}
@@ -171,8 +170,8 @@ class TestingValueStoreFactory : public SettingsStorageFactory {
}
// SettingsStorageFactory implementation.
- virtual ValueStore* Create(const base::FilePath& base_path,
- const std::string& extension_id) override {
+ ValueStore* Create(const base::FilePath& base_path,
+ const std::string& extension_id) override {
TestingValueStore* new_storage = new TestingValueStore();
DCHECK(!created_.count(extension_id));
created_[extension_id] = new_storage;
@@ -181,13 +180,12 @@ class TestingValueStoreFactory : public SettingsStorageFactory {
// Testing value stores don't actually create a real database. Don't delete
// any files.
- virtual void DeleteDatabaseIfExists(
- const base::FilePath& base_path,
- const std::string& extension_id) override {}
+ void DeleteDatabaseIfExists(const base::FilePath& base_path,
+ const std::string& extension_id) override {}
private:
// SettingsStorageFactory is refcounted.
- virtual ~TestingValueStoreFactory() {}
+ ~TestingValueStoreFactory() override {}
// None of these storage areas are owned by this factory, so care must be
// taken when calling GetExisting.

Powered by Google App Engine
This is Rietveld 408576698