chrome/browser/extensions/api/storage/sync_value_store_cache.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/sync_value_store_cache.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/storage/sync_storage_backend.h ('k') | chrome/browser/extensions/api/storage/syncable_settings_storage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/storage/sync_value_store_cache.h

diff --git a/chrome/browser/extensions/api/storage/sync_value_store_cache.h b/chrome/browser/extensions/api/storage/sync_value_store_cache.h

index a66300c92592fa70cdb529ed9c6e15ec21771be3..5f1a1f5d4c9cbbd7968acd378e72edd59a538507 100644

--- a/chrome/browser/extensions/api/storage/sync_value_store_cache.h

+++ b/chrome/browser/extensions/api/storage/sync_value_store_cache.h

@@ -34,15 +34,15 @@ class SyncValueStoreCache : public ValueStoreCache {

const scoped_refptr<SettingsStorageFactory>& factory,

const scoped_refptr<SettingsObserverList>& observers,

const base::FilePath& profile_path);

- virtual ~SyncValueStoreCache();

+ ~SyncValueStoreCache() override;

syncer::SyncableService* GetSyncableService(syncer::ModelType type) const;

// ValueStoreCache implementation:

- virtual void RunWithValueStoreForExtension(

+ void RunWithValueStoreForExtension(

const StorageCallback& callback,

scoped_refptr<const Extension> extension) override;

- virtual void DeleteStorageSoon(const std::string& extension_id) override;

+ void DeleteStorageSoon(const std::string& extension_id) override;

private:

void InitOnFileThread(const scoped_refptr<SettingsStorageFactory>& factory,