chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/proxy/proxy_api.h ('k') | chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher.h

diff --git a/chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher.h b/chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher.h

index f74404a3dcf7b754c1da7dcd6328dc63486d3de7..39eb7e1f5999df0a670c580a36b7e693a373b7ae 100644

--- a/chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher.h

+++ b/chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher.h

@@ -41,18 +41,16 @@ class ObfuscatedGaiaIdFetcher : public OAuth2ApiCallFlow {

// TODO(petewil): Someday let's make a profile keyed service to cache

// the Gaia ID.

explicit ObfuscatedGaiaIdFetcher(Delegate* delegate);

- virtual ~ObfuscatedGaiaIdFetcher();

+ ~ObfuscatedGaiaIdFetcher() override;

static OAuth2TokenService::ScopeSet GetScopes();

protected:

// OAuth2ApiCallFlow implementation

- virtual GURL CreateApiCallUrl() override;

- virtual std::string CreateApiCallBody() override;

- virtual void ProcessApiCallSuccess(

- const net::URLFetcher* source) override;

- virtual void ProcessApiCallFailure(

- const net::URLFetcher* source) override;

+ GURL CreateApiCallUrl() override;

+ std::string CreateApiCallBody() override;

+ void ProcessApiCallSuccess(const net::URLFetcher* source) override;

+ void ProcessApiCallFailure(const net::URLFetcher* source) override;

private:

FRIEND_TEST_ALL_PREFIXES(ObfuscatedGaiaIdFetcherTest, SetUp);