chrome/browser/extensions/api/proxy/proxy_api.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/proxy/proxy_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/processes/processes_api.h ('k') | chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/proxy/proxy_api.h

diff --git a/chrome/browser/extensions/api/proxy/proxy_api.h b/chrome/browser/extensions/api/proxy/proxy_api.h

index aea100fc415b966830644cb2dc705a13cd8de64c..62cbe73bd950dd2f4a731c0f65279af487c4ec67 100644

--- a/chrome/browser/extensions/api/proxy/proxy_api.h

+++ b/chrome/browser/extensions/api/proxy/proxy_api.h

@@ -28,14 +28,13 @@ class EventRouterForwarder;

class ProxyPrefTransformer : public PrefTransformerInterface {

public:

ProxyPrefTransformer();

- virtual ~ProxyPrefTransformer();

+ ~ProxyPrefTransformer() override;

// Implementation of PrefTransformerInterface.

- virtual base::Value* ExtensionToBrowserPref(const base::Value* extension_pref,

- std::string* error,

- bool* bad_message) override;

- virtual base::Value* BrowserToExtensionPref(

- const base::Value* browser_pref) override;

+ base::Value* ExtensionToBrowserPref(const base::Value* extension_pref,

+ std::string* error,

+ bool* bad_message) override;

+ base::Value* BrowserToExtensionPref(const base::Value* browser_pref) override;

private:

DISALLOW_COPY_AND_ASSIGN(ProxyPrefTransformer);