chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher_unittest.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher_unittest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher.h ('k') | chrome/browser/extensions/api/push_messaging/push_messaging_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher_unittest.cc

diff --git a/chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher_unittest.cc b/chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher_unittest.cc

index 01c2314f33a5a6714c920c08e447c0297189fca0..d26165ca3e35c222fefdee8dd4f6ec98eaff8610 100644

--- a/chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher_unittest.cc

+++ b/chrome/browser/extensions/api/push_messaging/obfuscated_gaia_id_fetcher_unittest.cc

@@ -20,16 +20,16 @@ static const char kNonDictionaryJsonData[] = "{ 0.5 }";

// Delegate class for catching notifications from the ObfuscatedGaiaIdFetcher.

class TestDelegate : public extensions::ObfuscatedGaiaIdFetcher::Delegate {

public:

- virtual void OnObfuscatedGaiaIdFetchSuccess(

+ void OnObfuscatedGaiaIdFetchSuccess(

const std::string& obfuscated_id) override {

succeeded_ = true;

}

- virtual void OnObfuscatedGaiaIdFetchFailure(

+ void OnObfuscatedGaiaIdFetchFailure(

const GoogleServiceAuthError& error) override {

failed_ = true;

}

TestDelegate() : succeeded_(false), failed_(false) {}

- virtual ~TestDelegate() {}

+ ~TestDelegate() override {}

bool succeeded() const { return succeeded_; }

bool failed() const { return failed_; }