chrome/browser/extensions/api/feedback_private/feedback_service_nonchromeos.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_service_nonchromeos.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/feedback_private/feedback_private_api.h ('k') | chrome/browser/extensions/api/file_system/entry_watcher_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/feedback_private/feedback_service_nonchromeos.cc

diff --git a/chrome/browser/extensions/api/feedback_private/feedback_service_nonchromeos.cc b/chrome/browser/extensions/api/feedback_private/feedback_service_nonchromeos.cc

index e958a1b16a23e3a12128bff6cf46a0057ec2ae34..11f33e3b7719bb068a266939772d72651599c96b 100644

--- a/chrome/browser/extensions/api/feedback_private/feedback_service_nonchromeos.cc

+++ b/chrome/browser/extensions/api/feedback_private/feedback_service_nonchromeos.cc

@@ -18,14 +18,14 @@ class FeedbackServiceImpl

public base::SupportsWeakPtr<FeedbackServiceImpl> {

public:

FeedbackServiceImpl();

- virtual ~FeedbackServiceImpl();

+ ~FeedbackServiceImpl() override;

- virtual std::string GetUserEmail() override;

- virtual void GetHistograms(std::string* histograms) override;

+ std::string GetUserEmail() override;

+ void GetHistograms(std::string* histograms) override;

private:

// Overridden from FeedbackService:

- virtual base::WeakPtr<FeedbackService> GetWeakPtr() override;

+ base::WeakPtr<FeedbackService> GetWeakPtr() override;

DISALLOW_COPY_AND_ASSIGN(FeedbackServiceImpl);

};