Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/feedback_private/feedback_private_api.h
diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.h b/chrome/browser/extensions/api/feedback_private/feedback_private_api.h
index d9798085f445e24f9ee332f45df0b8d103ba8c95..fc78aec9fb988d65e2f05a6cb54be439abad9fb4 100644
--- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.h
+++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.h
@@ -21,7 +21,7 @@ using extensions::api::feedback_private::SystemInformation;
class FeedbackPrivateAPI : public BrowserContextKeyedAPI {
public:
explicit FeedbackPrivateAPI(content::BrowserContext* context);
- virtual ~FeedbackPrivateAPI();
+ ~FeedbackPrivateAPI() override;
FeedbackService* GetService() const;
void RequestFeedback(const std::string& description_template,
@@ -58,10 +58,10 @@ class FeedbackPrivateGetStringsFunction : public ChromeSyncExtensionFunction {
}
protected:
- virtual ~FeedbackPrivateGetStringsFunction() {}
+ ~FeedbackPrivateGetStringsFunction() override {}
// SyncExtensionFunction overrides.
- virtual bool RunSync() override;
+ bool RunSync() override;
private:
static base::Closure* test_callback_;
@@ -73,8 +73,8 @@ class FeedbackPrivateGetUserEmailFunction : public ChromeSyncExtensionFunction {
FEEDBACKPRIVATE_GETUSEREMAIL);
protected:
- virtual ~FeedbackPrivateGetUserEmailFunction() {}
- virtual bool RunSync() override;
+ ~FeedbackPrivateGetUserEmailFunction() override {}
+ bool RunSync() override;
};
class FeedbackPrivateGetSystemInformationFunction
@@ -84,8 +84,8 @@ class FeedbackPrivateGetSystemInformationFunction
FEEDBACKPRIVATE_GETSYSTEMINFORMATION);
protected:
- virtual ~FeedbackPrivateGetSystemInformationFunction() {}
- virtual bool RunAsync() override;
+ ~FeedbackPrivateGetSystemInformationFunction() override {}
+ bool RunAsync() override;
private:
void OnCompleted(
@@ -99,8 +99,8 @@ class FeedbackPrivateSendFeedbackFunction
FEEDBACKPRIVATE_SENDFEEDBACK);
protected:
- virtual ~FeedbackPrivateSendFeedbackFunction() {}
- virtual bool RunAsync() override;
+ ~FeedbackPrivateSendFeedbackFunction() override {}
+ bool RunAsync() override;
private:
void OnCompleted(bool success);

Powered by Google App Engine
This is Rietveld 408576698