chrome/browser/extensions/api/file_system/entry_watcher_service.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/file_system/entry_watcher_service.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/feedback_private/feedback_service_nonchromeos.cc ('k') | chrome/browser/extensions/api/file_system/entry_watcher_service_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/file_system/entry_watcher_service.h

diff --git a/chrome/browser/extensions/api/file_system/entry_watcher_service.h b/chrome/browser/extensions/api/file_system/entry_watcher_service.h

index a75448e3c0bc46d40bd99c575fd1c129acdb263e..5b3ddd44210833c928774418587f93dd8aab0f08 100644

--- a/chrome/browser/extensions/api/file_system/entry_watcher_service.h

+++ b/chrome/browser/extensions/api/file_system/entry_watcher_service.h

@@ -43,7 +43,7 @@ class EntryWatcherService : public KeyedService,

content::BrowserContext* context)> GetFileSystemContextImplCallback;

explicit EntryWatcherService(content::BrowserContext* context);

- virtual ~EntryWatcherService();

+ ~EntryWatcherService() override;

// Watches a directory. Only one watcher can be set per the same |url| and

// |extension_id|.

@@ -61,8 +61,8 @@ class EntryWatcherService : public KeyedService,

const std::string& extension_id);

// storage::WatcherManager::Observer overrides.

- virtual void OnEntryChanged(const storage::FileSystemURL& url) override;

- virtual void OnEntryRemoved(const storage::FileSystemURL& url) override;

+ void OnEntryChanged(const storage::FileSystemURL& url) override;

+ void OnEntryRemoved(const storage::FileSystemURL& url) override;

// Sets a custom dispatcher for tests in order to be able to verify dispatched

// events.