Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1659)

Unified Diff: chrome/browser/extensions/api/notification_provider/notification_provider_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/notification_provider/notification_provider_api.h
diff --git a/chrome/browser/extensions/api/notification_provider/notification_provider_api.h b/chrome/browser/extensions/api/notification_provider/notification_provider_api.h
index 46c65374ed32bccaf18fe404243d01734f6bc831..012e06812eeedf26f08f1377593ef9f36e7d34e6 100644
--- a/chrome/browser/extensions/api/notification_provider/notification_provider_api.h
+++ b/chrome/browser/extensions/api/notification_provider/notification_provider_api.h
@@ -63,14 +63,14 @@ class NotificationProviderNotifyOnClearedFunction
NotificationProviderNotifyOnClearedFunction();
protected:
- virtual ~NotificationProviderNotifyOnClearedFunction();
+ ~NotificationProviderNotifyOnClearedFunction() override;
private:
DECLARE_EXTENSION_FUNCTION("notificationProvider.notifyOnCleared",
NOTIFICATIONPROVIDER_NOTIFYONCLEARED);
// UIThreadExtensionFunction implementation.
- virtual ExtensionFunction::ResponseAction Run() override;
+ ExtensionFunction::ResponseAction Run() override;
};
// Implememtation of NotifyOnClicked function of the API. It will inform the
@@ -82,14 +82,14 @@ class NotificationProviderNotifyOnClickedFunction
NotificationProviderNotifyOnClickedFunction();
protected:
- virtual ~NotificationProviderNotifyOnClickedFunction();
+ ~NotificationProviderNotifyOnClickedFunction() override;
private:
DECLARE_EXTENSION_FUNCTION("notificationProvider.notifyOnClicked",
NOTIFICATIONPROVIDER_NOTIFYONCLICKED);
// UIThreadExtensionFunction implementation.
- virtual ExtensionFunction::ResponseAction Run() override;
+ ExtensionFunction::ResponseAction Run() override;
};
// Implememtation of NotifyOnButtonClicked function of the API. It will inform
@@ -102,14 +102,14 @@ class NotificationProviderNotifyOnButtonClickedFunction
NotificationProviderNotifyOnButtonClickedFunction();
protected:
- virtual ~NotificationProviderNotifyOnButtonClickedFunction();
+ ~NotificationProviderNotifyOnButtonClickedFunction() override;
private:
DECLARE_EXTENSION_FUNCTION("notificationProvider.notifyOnButtonClicked",
NOTIFICATIONPROVIDER_NOTIFYONBUTTONCLICKED);
// UIThreadExtensionFunction implementation.
- virtual ExtensionFunction::ResponseAction Run() override;
+ ExtensionFunction::ResponseAction Run() override;
};
// Implememtation of NotifyOnPermissionLevelChanged function of the API. It will
@@ -121,7 +121,7 @@ class NotificationProviderNotifyOnPermissionLevelChangedFunction
NotificationProviderNotifyOnPermissionLevelChangedFunction();
protected:
- virtual ~NotificationProviderNotifyOnPermissionLevelChangedFunction();
+ ~NotificationProviderNotifyOnPermissionLevelChangedFunction() override;
private:
DECLARE_EXTENSION_FUNCTION(
@@ -129,7 +129,7 @@ class NotificationProviderNotifyOnPermissionLevelChangedFunction
NOTIFICATIONPROVIDER_NOTIFYONPERMISSIONLEVELCHANGED);
// UIThreadExtensionFunction implementation.
- virtual ExtensionFunction::ResponseAction Run() override;
+ ExtensionFunction::ResponseAction Run() override;
};
// Implememtation of NotifyOnShowSettings function of the API. It will inform
@@ -140,14 +140,14 @@ class NotificationProviderNotifyOnShowSettingsFunction
NotificationProviderNotifyOnShowSettingsFunction();
protected:
- virtual ~NotificationProviderNotifyOnShowSettingsFunction();
+ ~NotificationProviderNotifyOnShowSettingsFunction() override;
private:
DECLARE_EXTENSION_FUNCTION("notificationProvider.notifyOnShowSettings",
NOTIFICATIONPROVIDER_NOTIFYONSHOWSETTINGS);
// UIThreadExtensionFunction implementation.
- virtual ExtensionFunction::ResponseAction Run() override;
+ ExtensionFunction::ResponseAction Run() override;
};
// Implememtation of GetNotifier function of the API. It will get the notifier
@@ -158,14 +158,14 @@ class NotificationProviderGetNotifierFunction
NotificationProviderGetNotifierFunction();
protected:
- virtual ~NotificationProviderGetNotifierFunction();
+ ~NotificationProviderGetNotifierFunction() override;
private:
DECLARE_EXTENSION_FUNCTION("notificationProvider.getNotifier",
NOTIFICATIONPROVIDER_GETNOTIFIER);
// UIThreadExtensionFunction implementation.
- virtual ExtensionFunction::ResponseAction Run() override;
+ ExtensionFunction::ResponseAction Run() override;
};
// Implememtation of GetAllNotifiers function of the API. It will get all the
@@ -176,14 +176,14 @@ class NotificationProviderGetAllNotifiersFunction
NotificationProviderGetAllNotifiersFunction();
protected:
- virtual ~NotificationProviderGetAllNotifiersFunction();
+ ~NotificationProviderGetAllNotifiersFunction() override;
private:
DECLARE_EXTENSION_FUNCTION("notificationProvider.getAllNotifiers",
NOTIFICATIONPROVIDER_GETALLNOTIFIERS);
// UIThreadExtensionFunction implementation.
- virtual ExtensionFunction::ResponseAction Run() override;
+ ExtensionFunction::ResponseAction Run() override;
};
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698