Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2765)

Unified Diff: chrome/browser/extensions/api/notifications/notifications_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/notifications/notifications_api.h
diff --git a/chrome/browser/extensions/api/notifications/notifications_api.h b/chrome/browser/extensions/api/notifications/notifications_api.h
index 2f130b5d7642ba513e8a34ad8dfb90542cf4222d..b3ef00b9f2bd98571e7592900b0b96376a4fca81 100644
--- a/chrome/browser/extensions/api/notifications/notifications_api.h
+++ b/chrome/browser/extensions/api/notifications/notifications_api.h
@@ -25,7 +25,7 @@ class NotificationsApiFunction : public ChromeAsyncExtensionFunction {
protected:
NotificationsApiFunction();
- virtual ~NotificationsApiFunction();
+ ~NotificationsApiFunction() override;
bool CreateNotification(const std::string& id,
api::notifications::NotificationOptions* options);
@@ -45,7 +45,7 @@ class NotificationsApiFunction : public ChromeAsyncExtensionFunction {
virtual bool RunNotificationsApi() = 0;
// UITHreadExtensionFunction:
- virtual bool RunAsync() override;
+ bool RunAsync() override;
message_center::NotificationType MapApiTemplateTypeToType(
api::notifications::TemplateType type);
@@ -56,10 +56,10 @@ class NotificationsCreateFunction : public NotificationsApiFunction {
NotificationsCreateFunction();
// NotificationsApiFunction:
- virtual bool RunNotificationsApi() override;
+ bool RunNotificationsApi() override;
protected:
- virtual ~NotificationsCreateFunction();
+ ~NotificationsCreateFunction() override;
private:
scoped_ptr<api::notifications::Create::Params> params_;
@@ -72,10 +72,10 @@ class NotificationsUpdateFunction : public NotificationsApiFunction {
NotificationsUpdateFunction();
// NotificationsApiFunction:
- virtual bool RunNotificationsApi() override;
+ bool RunNotificationsApi() override;
protected:
- virtual ~NotificationsUpdateFunction();
+ ~NotificationsUpdateFunction() override;
private:
scoped_ptr<api::notifications::Update::Params> params_;
@@ -88,10 +88,10 @@ class NotificationsClearFunction : public NotificationsApiFunction {
NotificationsClearFunction();
// NotificationsApiFunction:
- virtual bool RunNotificationsApi() override;
+ bool RunNotificationsApi() override;
protected:
- virtual ~NotificationsClearFunction();
+ ~NotificationsClearFunction() override;
private:
scoped_ptr<api::notifications::Clear::Params> params_;
@@ -104,10 +104,10 @@ class NotificationsGetAllFunction : public NotificationsApiFunction {
NotificationsGetAllFunction();
// NotificationsApiFunction:
- virtual bool RunNotificationsApi() override;
+ bool RunNotificationsApi() override;
protected:
- virtual ~NotificationsGetAllFunction();
+ ~NotificationsGetAllFunction() override;
private:
DECLARE_EXTENSION_FUNCTION("notifications.getAll", NOTIFICATIONS_GET_ALL)
@@ -119,11 +119,11 @@ class NotificationsGetPermissionLevelFunction
NotificationsGetPermissionLevelFunction();
// NotificationsApiFunction:
- virtual bool CanRunWhileDisabled() const override;
- virtual bool RunNotificationsApi() override;
+ bool CanRunWhileDisabled() const override;
+ bool RunNotificationsApi() override;
protected:
- virtual ~NotificationsGetPermissionLevelFunction();
+ ~NotificationsGetPermissionLevelFunction() override;
private:
DECLARE_EXTENSION_FUNCTION("notifications.getPermissionLevel",

Powered by Google App Engine
This is Rietveld 408576698