chrome/browser/extensions/api/networking_private/networking_private_service_client_factory.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_service_client_factory.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/networking_private/networking_private_service_client_apitest.cc ('k') | chrome/browser/extensions/api/notification_provider/notification_provider_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/networking_private_service_client_factory.h

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_service_client_factory.h b/chrome/browser/extensions/api/networking_private/networking_private_service_client_factory.h

index 2a7cb931b446bff5f748c971664eb3841c132cfd..7ae4ad8d9914fb51e50cef9e687e8c38d6d336e2 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_service_client_factory.h

+++ b/chrome/browser/extensions/api/networking_private/networking_private_service_client_factory.h

@@ -28,13 +28,13 @@ class NetworkingPrivateServiceClientFactory

friend struct DefaultSingletonTraits<NetworkingPrivateServiceClientFactory>;

NetworkingPrivateServiceClientFactory();

- virtual ~NetworkingPrivateServiceClientFactory();

+ ~NetworkingPrivateServiceClientFactory() override;

// BrowserContextKeyedServiceFactory:

- virtual KeyedService* BuildServiceInstanceFor(

+ KeyedService* BuildServiceInstanceFor(

content::BrowserContext* browser_context) const override;

- virtual bool ServiceIsCreatedWithBrowserContext() const override;

- virtual bool ServiceIsNULLWhileTesting() const override;

+ bool ServiceIsCreatedWithBrowserContext() const override;

+ bool ServiceIsNULLWhileTesting() const override;

DISALLOW_COPY_AND_ASSIGN(NetworkingPrivateServiceClientFactory);

};