Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1388)

Unified Diff: chrome/browser/extensions/api/messaging/native_message_process_host.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/messaging/native_message_process_host.h
diff --git a/chrome/browser/extensions/api/messaging/native_message_process_host.h b/chrome/browser/extensions/api/messaging/native_message_process_host.h
index b730277a1422450f9b6422052987df9aef6dea17..fb00a5c2ff0e6eb75053fea0a37a692d2c5cffa7 100644
--- a/chrome/browser/extensions/api/messaging/native_message_process_host.h
+++ b/chrome/browser/extensions/api/messaging/native_message_process_host.h
@@ -39,7 +39,7 @@ class NativeMessageProcessHost :
#endif // !defined(OS_POSIX)
public NativeMessageHost {
public:
- virtual ~NativeMessageProcessHost();
+ ~NativeMessageProcessHost() override;
// Create using specified |launcher|. Used in tests.
static scoped_ptr<NativeMessageHost> CreateWithLauncher(
@@ -48,15 +48,14 @@ class NativeMessageProcessHost :
scoped_ptr<NativeProcessLauncher> launcher);
// extensions::NativeMessageHost implementation.
- virtual void OnMessage(const std::string& message) override;
- virtual void Start(Client* client) override;
- virtual scoped_refptr<base::SingleThreadTaskRunner> task_runner()
- const override;
+ void OnMessage(const std::string& message) override;
+ void Start(Client* client) override;
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner() const override;
#if defined(OS_POSIX)
// MessageLoopForIO::Watcher interface
- virtual void OnFileCanReadWithoutBlocking(int fd) override;
- virtual void OnFileCanWriteWithoutBlocking(int fd) override;
+ void OnFileCanReadWithoutBlocking(int fd) override;
+ void OnFileCanWriteWithoutBlocking(int fd) override;
#endif // !defined(OS_POSIX)
// Try and read a single message from |read_file_|. This should only be called

Powered by Google App Engine
This is Rietveld 408576698