Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1265)

Unified Diff: chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc
diff --git a/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc b/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc
index 958c9c5eeff8229216aaf72b0c752b33da305d9d..39ab93eea125add80cb5c0b81fced4dedd392d6a 100644
--- a/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc
+++ b/chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc
@@ -78,9 +78,9 @@ class FakeLauncher : public NativeProcessLauncher {
base::File(write_file, write_flags)));
}
- virtual void Launch(const GURL& origin,
- const std::string& native_host_name,
- LaunchedCallback callback) const override {
+ void Launch(const GURL& origin,
+ const std::string& native_host_name,
+ LaunchedCallback callback) const override {
callback.Run(NativeProcessLauncher::RESULT_SUCCESS,
base::kNullProcessHandle,
read_file_.Pass(), write_file_.Pass());
@@ -112,7 +112,7 @@ class NativeMessagingTest : public ::testing::Test,
base::RunLoop().RunUntilIdle();
}
- virtual void PostMessageFromNativeHost(const std::string& message) override {
+ void PostMessageFromNativeHost(const std::string& message) override {
last_message_ = message;
// Parse the message.
@@ -130,7 +130,7 @@ class NativeMessagingTest : public ::testing::Test,
run_loop_->Quit();
}
- virtual void CloseChannel(const std::string& error_message) override {
+ void CloseChannel(const std::string& error_message) override {
channel_closed_ = true;
if (run_loop_)
run_loop_->Quit();

Powered by Google App Engine
This is Rietveld 408576698