chrome/browser/extensions/api/messaging/native_message_port.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_message_port.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/native_message_port.h ('k') | chrome/browser/extensions/api/messaging/native_message_process_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/native_message_port.cc

diff --git a/chrome/browser/extensions/api/messaging/native_message_port.cc b/chrome/browser/extensions/api/messaging/native_message_port.cc

index 3bd403a9a16249c891c1a54cd2b32a8706edb1fe..31c5502a615e10d1f05ae710eee54358eb755ac7 100644

--- a/chrome/browser/extensions/api/messaging/native_message_port.cc

+++ b/chrome/browser/extensions/api/messaging/native_message_port.cc

@@ -22,13 +22,13 @@ class NativeMessagePort::Core : public NativeMessageHost::Client {

scoped_ptr<NativeMessageHost> host,

base::WeakPtr<NativeMessagePort> port,

scoped_refptr<base::SingleThreadTaskRunner> message_service_task_runner_);

- virtual ~Core();

+ ~Core() override;

void OnMessageFromChrome(const std::string& message);

// NativeMessageHost::Client implementation.

- virtual void PostMessageFromNativeHost(const std::string& message) override;

- virtual void CloseChannel(const std::string& error_message) override;

+ void PostMessageFromNativeHost(const std::string& message) override;

+ void CloseChannel(const std::string& error_message) override;

private:

scoped_ptr<NativeMessageHost> host_;