Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1409)

Unified Diff: chrome/browser/extensions/api/storage/syncable_settings_storage.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/storage/syncable_settings_storage.h
diff --git a/chrome/browser/extensions/api/storage/syncable_settings_storage.h b/chrome/browser/extensions/api/storage/syncable_settings_storage.h
index b278aca3030a633c6cdc3df19bc65c369edaa3c7..a5fb15047ce1f15f612afa7829db0d3922b69e69 100644
--- a/chrome/browser/extensions/api/storage/syncable_settings_storage.h
+++ b/chrome/browser/extensions/api/storage/syncable_settings_storage.h
@@ -31,26 +31,25 @@ class SyncableSettingsStorage : public ValueStore {
syncer::ModelType sync_type,
const syncer::SyncableService::StartSyncFlare& flare);
- virtual ~SyncableSettingsStorage();
+ ~SyncableSettingsStorage() override;
// ValueStore implementation.
- virtual size_t GetBytesInUse(const std::string& key) override;
- virtual size_t GetBytesInUse(const std::vector<std::string>& keys) override;
- virtual size_t GetBytesInUse() override;
- virtual ReadResult Get(const std::string& key) override;
- virtual ReadResult Get(const std::vector<std::string>& keys) override;
- virtual ReadResult Get() override;
- virtual WriteResult Set(
- WriteOptions options,
- const std::string& key,
- const base::Value& value) override;
- virtual WriteResult Set(
- WriteOptions options, const base::DictionaryValue& values) override;
- virtual WriteResult Remove(const std::string& key) override;
- virtual WriteResult Remove(const std::vector<std::string>& keys) override;
- virtual WriteResult Clear() override;
- virtual bool Restore() override;
- virtual bool RestoreKey(const std::string& key) override;
+ size_t GetBytesInUse(const std::string& key) override;
+ size_t GetBytesInUse(const std::vector<std::string>& keys) override;
+ size_t GetBytesInUse() override;
+ ReadResult Get(const std::string& key) override;
+ ReadResult Get(const std::vector<std::string>& keys) override;
+ ReadResult Get() override;
+ WriteResult Set(WriteOptions options,
+ const std::string& key,
+ const base::Value& value) override;
+ WriteResult Set(WriteOptions options,
+ const base::DictionaryValue& values) override;
+ WriteResult Remove(const std::string& key) override;
+ WriteResult Remove(const std::vector<std::string>& keys) override;
+ WriteResult Clear() override;
+ bool Restore() override;
+ bool RestoreKey(const std::string& key) override;
// Sync-related methods, analogous to those on SyncableService (handled by
// ExtensionSettings), but with looser guarantees about when the methods

Powered by Google App Engine
This is Rietveld 408576698