Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc
diff --git a/chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc b/chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc
index b51f6bd0fcb9eff44e76497abd5137654f6d60c6..b9a2e1e3b8e721ec9b080ecd22218dba16602069 100644
--- a/chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc
+++ b/chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc
@@ -30,9 +30,9 @@ class FakeDriveServiceFactory
explicit FakeDriveServiceFactory(
drive::FakeDriveService::ChangeObserver* change_observer)
: change_observer_(change_observer) {}
- virtual ~FakeDriveServiceFactory() {}
+ ~FakeDriveServiceFactory() override {}
- virtual scoped_ptr<drive::DriveServiceInterface> CreateDriveService(
+ scoped_ptr<drive::DriveServiceInterface> CreateDriveService(
OAuth2TokenService* oauth2_token_service,
net::URLRequestContextGetter* url_request_context_getter,
base::SequencedTaskRunner* blocking_task_runner) override {
@@ -59,14 +59,14 @@ class SyncFileSystemTest : public extensions::PlatformAppBrowserTest,
remote_service_(NULL) {
}
- virtual void SetUpInProcessBrowserTestFixture() override {
+ void SetUpInProcessBrowserTestFixture() override {
ExtensionApiTest::SetUpInProcessBrowserTestFixture();
real_minimum_preserved_space_ =
storage::QuotaManager::kMinimumPreserveForSystem;
storage::QuotaManager::kMinimumPreserveForSystem = 0;
}
- virtual void TearDownInProcessBrowserTestFixture() override {
+ void TearDownInProcessBrowserTestFixture() override {
storage::QuotaManager::kMinimumPreserveForSystem =
real_minimum_preserved_space_;
ExtensionApiTest::TearDownInProcessBrowserTestFixture();
@@ -81,7 +81,7 @@ class SyncFileSystemTest : public extensions::PlatformAppBrowserTest,
base::SequencedWorkerPool::SKIP_ON_SHUTDOWN);
}
- virtual void SetUpOnMainThread() override {
+ void SetUpOnMainThread() override {
ASSERT_TRUE(base_dir_.CreateUniqueTempDir());
SyncFileSystemServiceFactory* factory =
@@ -116,7 +116,7 @@ class SyncFileSystemTest : public extensions::PlatformAppBrowserTest,
}
// drive::FakeDriveService::ChangeObserver override.
- virtual void OnNewChangeAvailable() override {
+ void OnNewChangeAvailable() override {
sync_engine()->OnNotificationReceived();
}

Powered by Google App Engine
This is Rietveld 408576698