chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/sync_file_system/sync_file_system_api.h ('k') | chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc

diff --git a/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc b/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc

index 37b5a84969c71e1ec7d59c60a882612f6e5139c9..bb9482152f4c6a25da6a87fa01d57aaf9da9980a 100644

--- a/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc

+++ b/chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc

@@ -40,7 +40,7 @@ class SyncFileSystemApiTest : public ExtensionApiTest {

real_minimum_preserved_space_(0),

real_default_quota_(0) {}

- virtual void SetUpInProcessBrowserTestFixture() override {

+ void SetUpInProcessBrowserTestFixture() override {

ExtensionApiTest::SetUpInProcessBrowserTestFixture();

real_minimum_preserved_space_ =

@@ -54,7 +54,7 @@ class SyncFileSystemApiTest : public ExtensionApiTest {

storage::QuotaManager::kSyncableStorageDefaultHostQuota = 123456;

}

- virtual void TearDownInProcessBrowserTestFixture() override {

+ void TearDownInProcessBrowserTestFixture() override {

storage::QuotaManager::kMinimumPreserveForSystem =

real_minimum_preserved_space_;

storage::QuotaManager::kSyncableStorageDefaultHostQuota =

@@ -62,7 +62,7 @@ class SyncFileSystemApiTest : public ExtensionApiTest {

ExtensionApiTest::TearDownInProcessBrowserTestFixture();

}

- virtual void SetUpOnMainThread() override {

+ void SetUpOnMainThread() override {

// Must happen after the browser process is created because instantiating

// the factory will instantiate ExtensionSystemFactory which depends on

// ExtensionsBrowserClient setup in BrowserProcessImpl.