chrome/browser/extensions/api/synced_notifications_private/synced_notifications_private_api.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/synced_notifications_private/synced_notifications_private_api.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc ('k') | chrome/browser/extensions/api/synced_notifications_private/synced_notifications_shim.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/synced_notifications_private/synced_notifications_private_api.h

diff --git a/chrome/browser/extensions/api/synced_notifications_private/synced_notifications_private_api.h b/chrome/browser/extensions/api/synced_notifications_private/synced_notifications_private_api.h

index da928477930fffdb73381ce7ba6be594a3bd4de1..0e3323da2f0c023e7104b5bd5767de7160428be0 100644

--- a/chrome/browser/extensions/api/synced_notifications_private/synced_notifications_private_api.h

+++ b/chrome/browser/extensions/api/synced_notifications_private/synced_notifications_private_api.h

@@ -19,8 +19,8 @@ class SyncedNotificationsPrivateGetInitialDataFunction

SYNCEDNOTIFICATIONSPRIVATE_GETINITIALDATA);

protected:

- virtual ~SyncedNotificationsPrivateGetInitialDataFunction();

- virtual ResponseAction Run() override;

+ ~SyncedNotificationsPrivateGetInitialDataFunction() override;

+ ResponseAction Run() override;

private:

DISALLOW_COPY_AND_ASSIGN(SyncedNotificationsPrivateGetInitialDataFunction);

@@ -34,8 +34,8 @@ class SyncedNotificationsPrivateUpdateNotificationFunction

SYNCEDNOTIFICATIONSPRIVATE_UPDATENOTIFICATION);

protected:

- virtual ~SyncedNotificationsPrivateUpdateNotificationFunction();

- virtual ResponseAction Run() override;

+ ~SyncedNotificationsPrivateUpdateNotificationFunction() override;

+ ResponseAction Run() override;

private:

DISALLOW_COPY_AND_ASSIGN(

@@ -50,8 +50,8 @@ class SyncedNotificationsPrivateSetRenderContextFunction

SYNCEDNOTIFICATIONSPRIVATE_SETRENDERCONTEXT);

protected:

- virtual ~SyncedNotificationsPrivateSetRenderContextFunction();

- virtual ResponseAction Run() override;

+ ~SyncedNotificationsPrivateSetRenderContextFunction() override;

+ ResponseAction Run() override;

private:

DISALLOW_COPY_AND_ASSIGN(SyncedNotificationsPrivateSetRenderContextFunction);