chrome/browser/extensions/api/messaging/native_message_port.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_message_port.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/message_service.h ('k') | chrome/browser/extensions/api/messaging/native_message_port.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/native_message_port.h

diff --git a/chrome/browser/extensions/api/messaging/native_message_port.h b/chrome/browser/extensions/api/messaging/native_message_port.h

index 65711ae43389a430b154bbafb2facfeb8344edea..438b3176cb553c5c2471c90c47d4882422201b46 100644

--- a/chrome/browser/extensions/api/messaging/native_message_port.h

+++ b/chrome/browser/extensions/api/messaging/native_message_port.h

@@ -18,11 +18,11 @@ class NativeMessagePort : public MessageService::MessagePort {

NativeMessagePort(base::WeakPtr<MessageService> message_service,

int port_id,

scoped_ptr<NativeMessageHost> native_message_host);

- virtual ~NativeMessagePort();

+ ~NativeMessagePort() override;

// MessageService::MessagePort implementation.

- virtual void DispatchOnMessage(const Message& message,

- int target_port_id) override;

+ void DispatchOnMessage(const Message& message, int target_port_id) override;

private:

class Core;

void PostMessageFromNativeHost(const std::string& message);