chrome/browser/extensions/api/messaging/message_service.h - Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/message_service.h

Issue 666153002: Standardize usage of virtual/override/final in chrome/browser/extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/incognito_connectability.h ('k') | chrome/browser/extensions/api/messaging/native_message_port.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/message_service.h

diff --git a/chrome/browser/extensions/api/messaging/message_service.h b/chrome/browser/extensions/api/messaging/message_service.h

index 23bf7e87ca9463149b14c9b06d80685be7fd111c..6dcde00c9f86060846fa5c4145a157e25a1eaa60 100644

--- a/chrome/browser/extensions/api/messaging/message_service.h

+++ b/chrome/browser/extensions/api/messaging/message_service.h

@@ -119,7 +119,7 @@ class MessageService : public BrowserContextKeyedAPI,

static void AllocatePortIdPair(int* port1, int* port2);

explicit MessageService(content::BrowserContext* context);

- virtual ~MessageService();

+ ~MessageService() override;

// BrowserContextKeyedAPI implementation.

static BrowserContextKeyedAPIFactory<MessageService>* GetFactoryInstance();

@@ -196,9 +196,9 @@ class MessageService : public BrowserContextKeyedAPI,

void AddChannel(MessageChannel* channel, int receiver_port_id);

// content::NotificationObserver interface.

- virtual void Observe(int type,

- const content::NotificationSource& source,

- const content::NotificationDetails& details) override;

+ void Observe(int type,

+ const content::NotificationSource& source,

+ const content::NotificationDetails& details) override;

// A process that might be in our list of channels has closed.

void OnProcessClosed(content::RenderProcessHost* process);