components/signin/core/browser/fake_auth_status_provider.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/fake_auth_status_provider.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/signin/core/browser/account_tracker_service_unittest.cc ('k') | components/signin/core/browser/mutable_profile_oauth2_token_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/fake_auth_status_provider.h

diff --git a/components/signin/core/browser/fake_auth_status_provider.h b/components/signin/core/browser/fake_auth_status_provider.h

index 7254179c22c7e29e20818785173a3d20504fb328..ce2cca921af89036432dc56d74d547b47536d0a0 100644

--- a/components/signin/core/browser/fake_auth_status_provider.h

+++ b/components/signin/core/browser/fake_auth_status_provider.h

@@ -14,7 +14,7 @@ class FakeAuthStatusProvider

: public SigninErrorController::AuthStatusProvider {

public:

explicit FakeAuthStatusProvider(SigninErrorController* error);

- virtual ~FakeAuthStatusProvider();

+ ~FakeAuthStatusProvider() override;

// Sets the auth error that this provider reports to SigninErrorController.

// Also notifies SigninErrorController via AuthStatusChanged().

@@ -27,9 +27,9 @@ class FakeAuthStatusProvider

}

// AuthStatusProvider implementation.

- virtual std::string GetAccountId() const override;

- virtual std::string GetUsername() const override;

- virtual GoogleServiceAuthError GetAuthStatus() const override;

+ std::string GetAccountId() const override;

+ std::string GetUsername() const override;

+ GoogleServiceAuthError GetAuthStatus() const override;

private:

SigninErrorController* error_provider_;