Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Unified Diff: components/signin/core/browser/mutable_profile_oauth2_token_service.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/mutable_profile_oauth2_token_service.h
diff --git a/components/signin/core/browser/mutable_profile_oauth2_token_service.h b/components/signin/core/browser/mutable_profile_oauth2_token_service.h
index e7db6a2a4aa14b4b273ff5ca437b3d05a4d03988..a06efba58b9588e1a90ba5dbdfda40e60c026dba 100644
--- a/components/signin/core/browser/mutable_profile_oauth2_token_service.h
+++ b/components/signin/core/browser/mutable_profile_oauth2_token_service.h
@@ -20,17 +20,16 @@ class MutableProfileOAuth2TokenService : public ProfileOAuth2TokenService,
public WebDataServiceConsumer {
public:
// ProfileOAuth2TokenService overrides.
- virtual void Shutdown() override;
- virtual std::vector<std::string> GetAccounts() override;
+ void Shutdown() override;
+ std::vector<std::string> GetAccounts() override;
// The below three methods should be called only on the thread on which this
// object was created.
- virtual void LoadCredentials(const std::string& primary_account_id) override;
- virtual void UpdateCredentials(const std::string& account_id,
- const std::string& refresh_token) override;
- virtual void RevokeAllCredentials() override;
- virtual bool RefreshTokenIsAvailable(const std::string& account_id) const
- override;
+ void LoadCredentials(const std::string& primary_account_id) override;
+ void UpdateCredentials(const std::string& account_id,
+ const std::string& refresh_token) override;
+ void RevokeAllCredentials() override;
+ bool RefreshTokenIsAvailable(const std::string& account_id) const override;
// Revokes credentials related to |account_id|.
void RevokeCredentials(const std::string& account_id);
@@ -41,7 +40,7 @@ class MutableProfileOAuth2TokenService : public ProfileOAuth2TokenService,
AccountInfo(ProfileOAuth2TokenService* token_service,
const std::string& account_id,
const std::string& refresh_token);
- virtual ~AccountInfo();
+ ~AccountInfo() override;
const std::string& refresh_token() const { return refresh_token_; }
void set_refresh_token(const std::string& token) {
@@ -51,9 +50,9 @@ class MutableProfileOAuth2TokenService : public ProfileOAuth2TokenService,
void SetLastAuthError(const GoogleServiceAuthError& error);
// SigninErrorController::AuthStatusProvider implementation.
- virtual std::string GetAccountId() const override;
- virtual std::string GetUsername() const override;
- virtual GoogleServiceAuthError GetAuthStatus() const override;
+ std::string GetAccountId() const override;
+ std::string GetUsername() const override;
+ GoogleServiceAuthError GetAuthStatus() const override;
private:
ProfileOAuth2TokenService* token_service_;
@@ -72,19 +71,19 @@ class MutableProfileOAuth2TokenService : public ProfileOAuth2TokenService,
friend class MutableProfileOAuth2TokenServiceTest;
MutableProfileOAuth2TokenService();
- virtual ~MutableProfileOAuth2TokenService();
+ ~MutableProfileOAuth2TokenService() override;
// OAuth2TokenService implementation.
- virtual OAuth2AccessTokenFetcher* CreateAccessTokenFetcher(
+ OAuth2AccessTokenFetcher* CreateAccessTokenFetcher(
const std::string& account_id,
net::URLRequestContextGetter* getter,
OAuth2AccessTokenConsumer* consumer) override;
- virtual net::URLRequestContextGetter* GetRequestContext() override;
+ net::URLRequestContextGetter* GetRequestContext() override;
// Updates the internal cache of the result from the most-recently-completed
// auth request (used for reporting errors to the user).
- virtual void UpdateAuthError(const std::string& account_id,
- const GoogleServiceAuthError& error) override;
+ void UpdateAuthError(const std::string& account_id,
+ const GoogleServiceAuthError& error) override;
virtual std::string GetRefreshToken(const std::string& account_id) const;
@@ -103,9 +102,8 @@ class MutableProfileOAuth2TokenService : public ProfileOAuth2TokenService,
CanonicalizeAccountId);
// WebDataServiceConsumer implementation:
- virtual void OnWebDataServiceRequestDone(
- WebDataServiceBase::Handle handle,
- const WDTypedResult* result) override;
+ void OnWebDataServiceRequestDone(WebDataServiceBase::Handle handle,
+ const WDTypedResult* result) override;
// Loads credentials into in memory stucture.
void LoadAllCredentialsIntoMemory(

Powered by Google App Engine
This is Rietveld 408576698