components/signin/core/browser/account_tracker_service_unittest.cc - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/account_tracker_service_unittest.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/signin/core/browser/account_tracker_service.cc ('k') | components/signin/core/browser/fake_auth_status_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/signin/core/browser/account_tracker_service_unittest.cc

diff --git a/components/signin/core/browser/account_tracker_service_unittest.cc b/components/signin/core/browser/account_tracker_service_unittest.cc

index 8b340dc7ed03f63324c4ac0729e4f2d4a1e81943..64b83b0dcebcac5437623511826a349fc5709c0d 100644

--- a/components/signin/core/browser/account_tracker_service_unittest.cc

+++ b/components/signin/core/browser/account_tracker_service_unittest.cc

@@ -98,7 +98,7 @@ std::string Str(const std::vector<TrackingEvent>& events) {

class AccountTrackerObserver : public AccountTrackerService::Observer {

public:

AccountTrackerObserver() {}

- virtual ~AccountTrackerObserver() {}

+ ~AccountTrackerObserver() override {}

void Clear();

void SortEventsByUser();

@@ -113,10 +113,8 @@ class AccountTrackerObserver : public AccountTrackerService::Observer {

private:

// AccountTrackerService::Observer implementation

- virtual void OnAccountUpdated(

- const AccountTrackerService::AccountInfo& ids) override;

- virtual void OnAccountRemoved(

- const AccountTrackerService::AccountInfo& ids) override;

+ void OnAccountUpdated(const AccountTrackerService::AccountInfo& ids) override;

+ void OnAccountRemoved(const AccountTrackerService::AccountInfo& ids) override;

testing::AssertionResult CheckEvents(

const std::vector<TrackingEvent>& events);