components/password_manager/core/browser/password_store_default.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_default.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_store.h ('k') | components/password_manager/core/browser/password_syncable_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store_default.h

diff --git a/components/password_manager/core/browser/password_store_default.h b/components/password_manager/core/browser/password_store_default.h

index f60183f0fac8e2ebc3b085ddc62ba015335a60ea..7dcf4fb4811e020d4d6b438931b1ac34c6383d80 100644

--- a/components/password_manager/core/browser/password_store_default.h

+++ b/components/password_manager/core/browser/password_store_default.h

@@ -24,31 +24,30 @@ class PasswordStoreDefault : public PasswordStore {

LoginDatabase* login_db);

protected:

- virtual ~PasswordStoreDefault();

+ ~PasswordStoreDefault() override;

// Implements PasswordStore interface.

- virtual void ReportMetricsImpl(const std::string& sync_username) override;

- virtual PasswordStoreChangeList AddLoginImpl(

+ void ReportMetricsImpl(const std::string& sync_username) override;

+ PasswordStoreChangeList AddLoginImpl(

const autofill::PasswordForm& form) override;

- virtual PasswordStoreChangeList UpdateLoginImpl(

+ PasswordStoreChangeList UpdateLoginImpl(

const autofill::PasswordForm& form) override;

- virtual PasswordStoreChangeList RemoveLoginImpl(

+ PasswordStoreChangeList RemoveLoginImpl(

const autofill::PasswordForm& form) override;

- virtual PasswordStoreChangeList RemoveLoginsCreatedBetweenImpl(

+ PasswordStoreChangeList RemoveLoginsCreatedBetweenImpl(

base::Time delete_begin,

base::Time delete_end) override;

- virtual PasswordStoreChangeList RemoveLoginsSyncedBetweenImpl(

+ PasswordStoreChangeList RemoveLoginsSyncedBetweenImpl(

base::Time delete_begin,

base::Time delete_end) override;

- virtual void GetLoginsImpl(

- const autofill::PasswordForm& form,

- AuthorizationPromptPolicy prompt_policy,

- const ConsumerCallbackRunner& callback_runner) override;

- virtual void GetAutofillableLoginsImpl(GetLoginsRequest* request) override;

- virtual void GetBlacklistLoginsImpl(GetLoginsRequest* request) override;

- virtual bool FillAutofillableLogins(

+ void GetLoginsImpl(const autofill::PasswordForm& form,

+ AuthorizationPromptPolicy prompt_policy,

+ const ConsumerCallbackRunner& callback_runner) override;

+ void GetAutofillableLoginsImpl(GetLoginsRequest* request) override;

+ void GetBlacklistLoginsImpl(GetLoginsRequest* request) override;

+ bool FillAutofillableLogins(

std::vector<autofill::PasswordForm*>* forms) override;

- virtual bool FillBlacklistLogins(

+ bool FillBlacklistLogins(

std::vector<autofill::PasswordForm*>* forms) override;

protected: