components/password_manager/core/browser/password_syncable_service.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_syncable_service.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_store_default.h ('k') | components/password_manager/core/browser/stub_password_manager_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_syncable_service.h

diff --git a/components/password_manager/core/browser/password_syncable_service.h b/components/password_manager/core/browser/password_syncable_service.h

index afec988d0e01f22e770197c36c09d01f1bdb6095..24ad460ba5d3a7b7b190fdbd6426e11060140d31 100644

--- a/components/password_manager/core/browser/password_syncable_service.h

+++ b/components/password_manager/core/browser/password_syncable_service.h

@@ -42,18 +42,17 @@ class PasswordSyncableService : public syncer::SyncableService,

// |password_store|, the constructor doesn't take ownership of the

// |password_store|.

explicit PasswordSyncableService(PasswordStoreSync* password_store);

- virtual ~PasswordSyncableService();

+ ~PasswordSyncableService() override;

// syncer::SyncableService:

- virtual syncer::SyncMergeResult MergeDataAndStartSyncing(

+ syncer::SyncMergeResult MergeDataAndStartSyncing(

syncer::ModelType type,

const syncer::SyncDataList& initial_sync_data,

scoped_ptr<syncer::SyncChangeProcessor> sync_processor,

scoped_ptr<syncer::SyncErrorFactory> error_handler) override;

- virtual void StopSyncing(syncer::ModelType type) override;

- virtual syncer::SyncDataList GetAllSyncData(

- syncer::ModelType type) const override;

- virtual syncer::SyncError ProcessSyncChanges(

+ void StopSyncing(syncer::ModelType type) override;

+ syncer::SyncDataList GetAllSyncData(syncer::ModelType type) const override;

+ syncer::SyncError ProcessSyncChanges(

const tracked_objects::Location& from_here,

const syncer::SyncChangeList& change_list) override;