components/password_manager/core/browser/password_store.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager_unittest.cc ('k') | components/password_manager/core/browser/password_store_default.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store.h

diff --git a/components/password_manager/core/browser/password_store.h b/components/password_manager/core/browser/password_store.h

index 9afb529ecdce33d60370b4dc52244e2ae70dd1e1..d93c66056b066185a791a05b480c694c21c5f00a 100644

--- a/components/password_manager/core/browser/password_store.h

+++ b/components/password_manager/core/browser/password_store.h

@@ -196,7 +196,7 @@ class PasswordStore : protected PasswordStoreSync,

typedef base::Callback<PasswordStoreChangeList(void)> ModificationTask;

- virtual ~PasswordStore();

+ ~PasswordStore() override;

// Get the TaskRunner to use for PasswordStore background tasks.

// By default, a SingleThreadTaskRunner on the DB thread is used, but

@@ -255,8 +255,7 @@ class PasswordStore : protected PasswordStoreSync,

// Called by WrapModificationTask() once the underlying data-modifying

// operation has been performed. Notifies observers that password store data

// may have been changed.

- virtual void NotifyLoginsChanged(

- const PasswordStoreChangeList& changes) override;

+ void NotifyLoginsChanged(const PasswordStoreChangeList& changes) override;

// TaskRunner for tasks that run on the main thread (usually the UI thread).

scoped_refptr<base::SingleThreadTaskRunner> main_thread_runner_;