components/password_manager/core/browser/browser_save_password_progress_logger.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/browser_save_password_progress_logger.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/renderer/credential_manager_client.h ('k') | components/password_manager/core/browser/password_autofill_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/browser_save_password_progress_logger.h

diff --git a/components/password_manager/core/browser/browser_save_password_progress_logger.h b/components/password_manager/core/browser/browser_save_password_progress_logger.h

index 1e3b34474cda8a85702dfce761e1bd4134a33cdd..883461c4044c255885b994b2315a94009cc220f9 100644

--- a/components/password_manager/core/browser/browser_save_password_progress_logger.h

+++ b/components/password_manager/core/browser/browser_save_password_progress_logger.h

@@ -19,11 +19,11 @@ class BrowserSavePasswordProgressLogger

: public autofill::SavePasswordProgressLogger {

public:

explicit BrowserSavePasswordProgressLogger(PasswordManagerClient* client);

- virtual ~BrowserSavePasswordProgressLogger();

+ ~BrowserSavePasswordProgressLogger() override;

protected:

// autofill::SavePasswordProgressLogger:

- virtual void SendLog(const std::string& log) override;

+ void SendLog(const std::string& log) override;

private:

// The PasswordManagerClient to which logs can be sent for display. The client