components/password_manager/core/browser/password_autofill_manager.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_autofill_manager.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/browser_save_password_progress_logger.h ('k') | components/password_manager/core/browser/password_autofill_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_autofill_manager.h

diff --git a/components/password_manager/core/browser/password_autofill_manager.h b/components/password_manager/core/browser/password_autofill_manager.h

index 8172877ee4f1c942e31f6bcfe616e175eea0d6eb..88420c9a279f905aad27da8bf8ca5676aa50699d 100644

--- a/components/password_manager/core/browser/password_autofill_manager.h

+++ b/components/password_manager/core/browser/password_autofill_manager.h

@@ -28,15 +28,14 @@ class PasswordAutofillManager : public autofill::AutofillPopupDelegate {

virtual ~PasswordAutofillManager();

// AutofillPopupDelegate implementation.

- virtual void OnPopupShown() override;

- virtual void OnPopupHidden() override;

- virtual void DidSelectSuggestion(const base::string16& value,

- int identifier) override;

- virtual void DidAcceptSuggestion(const base::string16& value,

- int identifier) override;

- virtual void RemoveSuggestion(const base::string16& value,

- int identifier) override;

- virtual void ClearPreviewedForm() override;

+ void OnPopupShown() override;

+ void OnPopupHidden() override;

+ void DidSelectSuggestion(const base::string16& value,

+ int identifier) override;

+ void DidAcceptSuggestion(const base::string16& value,

+ int identifier) override;

+ void RemoveSuggestion(const base::string16& value, int identifier) override;

+ void ClearPreviewedForm() override;

// Invoked when a password mapping is added.

void OnAddPasswordFormMapping(