components/password_manager/content/renderer/credential_manager_client.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/renderer/credential_manager_client.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/password_manager_internals_service_factory.h ('k') | components/password_manager/core/browser/browser_save_password_progress_logger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/renderer/credential_manager_client.h

diff --git a/components/password_manager/content/renderer/credential_manager_client.h b/components/password_manager/content/renderer/credential_manager_client.h

index d88b5c0b9abe08b639f3aa6cc3274482f80cdb74..a37c1d58a97c7d6c0d3c1fb47bbcfbeffb65d73f 100644

--- a/components/password_manager/content/renderer/credential_manager_client.h

+++ b/components/password_manager/content/renderer/credential_manager_client.h

@@ -49,10 +49,10 @@ class CredentialManagerClient : public blink::WebCredentialManagerClient,

public content::RenderViewObserver {

public:

explicit CredentialManagerClient(content::RenderView* render_view);

- virtual ~CredentialManagerClient();

+ ~CredentialManagerClient() override;

// RenderViewObserver:

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ bool OnMessageReceived(const IPC::Message& message) override;

// Message handlers for messages from the browser process:

virtual void OnAcknowledgeFailedSignIn(int request_id);