Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: components/keyed_service/content/browser_context_keyed_service_factory.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/keyed_service/content/browser_context_keyed_service_factory.h
diff --git a/components/keyed_service/content/browser_context_keyed_service_factory.h b/components/keyed_service/content/browser_context_keyed_service_factory.h
index 8ad8e136d5c1d6f3f8bef348dd2ffe8fb3212652..29637d4c82e6d92b9fc44e29cc8a856d2a1dda64 100644
--- a/components/keyed_service/content/browser_context_keyed_service_factory.h
+++ b/components/keyed_service/content/browser_context_keyed_service_factory.h
@@ -56,7 +56,7 @@ class KEYED_SERVICE_EXPORT BrowserContextKeyedServiceFactory
// {}
BrowserContextKeyedServiceFactory(const char* name,
BrowserContextDependencyManager* manager);
- virtual ~BrowserContextKeyedServiceFactory();
+ ~BrowserContextKeyedServiceFactory() override;
// Common implementation that maps |context| to some service object. Deals
// with incognito contexts per subclass instructions with
@@ -91,15 +91,12 @@ class KEYED_SERVICE_EXPORT BrowserContextKeyedServiceFactory
// Secondly, BrowserContextDestroyed() is called on every ServiceFactory
// and the default implementation removes it from |mapping_| and deletes
// the pointer.
- virtual void BrowserContextShutdown(content::BrowserContext* context)
- override;
- virtual void BrowserContextDestroyed(content::BrowserContext* context)
- override;
-
- virtual void SetEmptyTestingFactory(content::BrowserContext* context)
- override;
- virtual bool HasTestingFactory(content::BrowserContext* context) override;
- virtual void CreateServiceNow(content::BrowserContext* context) override;
+ void BrowserContextShutdown(content::BrowserContext* context) override;
+ void BrowserContextDestroyed(content::BrowserContext* context) override;
+
+ void SetEmptyTestingFactory(content::BrowserContext* context) override;
+ bool HasTestingFactory(content::BrowserContext* context) override;
+ void CreateServiceNow(content::BrowserContext* context) override;
private:
friend class BrowserContextDependencyManager;

Powered by Google App Engine
This is Rietveld 408576698