components/keyed_service/content/browser_context_dependency_manager_unittest.cc - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/keyed_service/content/browser_context_dependency_manager_unittest.cc

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/json_schema/json_schema_validator_unittest.cc ('k') | components/keyed_service/content/browser_context_keyed_service_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/keyed_service/content/browser_context_dependency_manager_unittest.cc

diff --git a/components/keyed_service/content/browser_context_dependency_manager_unittest.cc b/components/keyed_service/content/browser_context_dependency_manager_unittest.cc

index e3bbdc1149b3eeb8f040170884216a4333d8b4ff..fe8e0883ce36709c2d10fcc75fd57b4aa2e47e98 100644

--- a/components/keyed_service/content/browser_context_dependency_manager_unittest.cc

+++ b/components/keyed_service/content/browser_context_dependency_manager_unittest.cc

@@ -33,14 +33,13 @@ class TestService : public BrowserContextKeyedServiceFactory {

name_(name),

fill_on_shutdown_(fill_on_shutdown) {}

- virtual KeyedService* BuildServiceInstanceFor(

+ KeyedService* BuildServiceInstanceFor(

content::BrowserContext* context) const override {

ADD_FAILURE() << "This isn't part of the tests!";

return NULL;

}

- virtual void BrowserContextShutdown(content::BrowserContext* context)

- override {

+ void BrowserContextShutdown(content::BrowserContext* context) override {

fill_on_shutdown_->push_back(name_);

}