components/keyed_service/content/refcounted_browser_context_keyed_service_factory.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/keyed_service/content/refcounted_browser_context_keyed_service_factory.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/keyed_service/content/browser_context_keyed_service_factory.h ('k') | components/metrics/daily_event_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/keyed_service/content/refcounted_browser_context_keyed_service_factory.h

diff --git a/components/keyed_service/content/refcounted_browser_context_keyed_service_factory.h b/components/keyed_service/content/refcounted_browser_context_keyed_service_factory.h

index 729b49b304eff97f584cc1647228c0cf9e718bac..f6f49ca87bfd1d27e737e937022c75f0059079fd 100644

--- a/components/keyed_service/content/refcounted_browser_context_keyed_service_factory.h

+++ b/components/keyed_service/content/refcounted_browser_context_keyed_service_factory.h

@@ -55,7 +55,7 @@ class KEYED_SERVICE_EXPORT RefcountedBrowserContextKeyedServiceFactory

RefcountedBrowserContextKeyedServiceFactory(

const char* name,

BrowserContextDependencyManager* manager);

- virtual ~RefcountedBrowserContextKeyedServiceFactory();

+ ~RefcountedBrowserContextKeyedServiceFactory() override;

scoped_refptr<RefcountedKeyedService> GetServiceForBrowserContext(

content::BrowserContext* context,

@@ -71,14 +71,11 @@ class KEYED_SERVICE_EXPORT RefcountedBrowserContextKeyedServiceFactory

virtual scoped_refptr<RefcountedKeyedService> BuildServiceInstanceFor(

content::BrowserContext* context) const = 0;

- virtual void BrowserContextShutdown(content::BrowserContext* context)

- override;

- virtual void BrowserContextDestroyed(content::BrowserContext* context)

- override;

- virtual void SetEmptyTestingFactory(content::BrowserContext* context)

- override;

- virtual bool HasTestingFactory(content::BrowserContext* context) override;

- virtual void CreateServiceNow(content::BrowserContext* context) override;

+ void BrowserContextShutdown(content::BrowserContext* context) override;

+ void BrowserContextDestroyed(content::BrowserContext* context) override;

+ void SetEmptyTestingFactory(content::BrowserContext* context) override;

+ bool HasTestingFactory(content::BrowserContext* context) override;

+ void CreateServiceNow(content::BrowserContext* context) override;

private:

typedef std::map<content::BrowserContext*,