components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h - Issue 666133002: Standardize usage of virtual/override/final in components/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h

Issue 666133002: Standardize usage of virtual/override/final in components/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_usage_stats.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h

index 126e5bdb91ff801874a827819bb87d13b983ad8e..64698d3517af21a7e041802c4538f743f0409b74 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.h

@@ -27,15 +27,15 @@ class DataReductionProxyStatisticsPrefs;

class TestDataReductionProxyConfig : public DataReductionProxyConfigurator {

public:

TestDataReductionProxyConfig();

- virtual ~TestDataReductionProxyConfig() {}

- virtual void Enable(bool restricted,

- bool fallback_restricted,

- const std::string& primary_origin,

- const std::string& fallback_origin,

- const std::string& ssl_origin) override;

- virtual void Disable() override;

- virtual void AddHostPatternToBypass(const std::string& pattern) override {}

- virtual void AddURLPatternToBypass(const std::string& pattern) override {}

+ ~TestDataReductionProxyConfig() override {}

+ void Enable(bool restricted,

+ bool fallback_restricted,

+ const std::string& primary_origin,

+ const std::string& fallback_origin,

+ const std::string& ssl_origin) override;

+ void Disable() override;

+ void AddHostPatternToBypass(const std::string& pattern) override {}

+ void AddURLPatternToBypass(const std::string& pattern) override {}

// True if the proxy has been enabled, i.e., only after |Enable| has been

// called. Defaults to false.